Ticket #3144 (closed defect: invalid)

Opened 5 years ago

Last modified 5 years ago

key.c "flag" undeclared

Reported by: matzeri Owned by:
Priority: major Milestone:
Component: mc-core Version: 4.8.11
Keywords: Cc:
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Description (last modified by andrew_b) (diff)

Building on cygwin:

/pub/devel/mc/mc-4.8.11-1/src/mc-4.8.11/lib/tty/key.c: In function 'tty_get_event':

CC tty.lo

/pub/devel/mc/mc-4.8.11-1/src/mc-4.8.11/lib/tty/key.c:2121:5: error: 'flag' undeclared (first use in this function)

flag = is_wintouched (stdscr);

/pub/devel/mc/mc-4.8.11-1/src/mc-4.8.11/lib/tty/key.c:2121:5: note: each undeclared identifier is reported only once for each function it appears in
Makefile:555: recipe for target 'key.lo' failed

Comparing the 4.10 and 4.11, the definition was moved inside a block
and not more visible

@@ -1955,7 +1946,6 @@
 tty_get_event (struct Gpm_Event *event, gboolean redo_event, gboolean block)
 {
     int c;
-    static int flag = 0;        /* Return value from select */
 #ifdef HAVE_LIBGPM
     static struct Gpm_Event ev; /* Mouse event */
 #endif
@@ -1988,6 +1978,7 @@
     while (pending_keys == NULL)
     {
         int nfd;
+        static int flag = 0;    /* Return value from select */
         fd_set select_set;

Change History

comment:1 Changed 5 years ago by andrew_b

  • Status changed from new to closed
  • Resolution set to invalid
  • Description modified (diff)
  • Milestone Future Releases deleted

This is already fixed in #3114.

Note: See TracTickets for help on using tickets.