Ticket #3140 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

trailing newline check applied too early when exiting

Reported by: ossi Owned by: andrew_b
Priority: major Milestone: 4.8.12
Component: mcedit Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

the fix for #46 added the check way too early for the editor exit case (editcmd.c:1790 in the patch). it shouldn't be done until it is established that the user actually wants to save the file, otherwise it's impossible to exit without saving at all.

btw, "The file you are saving is not finished with a newline" isn't very good english. it should be "The file you are saving does not end with a newline".

Change History

comment:1 Changed 3 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.12

Branch: 3140_check_mewline
changeset:c895eb6194b4b8f1e3ab87e626e7cf1cc2e6594f

TODO: update po/*.po before merge.

comment:2 Changed 3 years ago by slavazanko

  • Votes for changeset set to slavazanko
  • Branch state changed from on review to approved

comment:3 Changed 3 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

comment:4 Changed 3 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.