Ticket #3125 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Stop overriding precmd on zsh

Reported by: z0rc Owned by: andrew_b
Priority: major Milestone: 4.8.12
Component: mc-core Version: master
Keywords: Cc: gotar@…
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

MC overrides precmd function in subshell.c. Please stop doing this as precmd may be already defined by user (many custom themes use it). In this case you need to put your stuff into custom function e.g. "_mc_precmd () { ... }" and then do "precmd_functions+=_mc_precmd"

See http://zsh.sourceforge.net/Doc/Release/Functions.html#Hook-Functions and http://www.zsh.org/mla/users/2007/msg00897.html for details.

Attachments

0001-Ticket-3125-3121-don-t-override-precmd-on-Zsh.patch (991 bytes) - added by z0rc 3 years ago.

Change History

comment:1 Changed 3 years ago by z0rc

  • Keywords patch added
  • Milestone changed from Future Releases to 4.8.12

Here is patch for this issue. Also it effectively fixes #3121. Though I'm still not sure why it fixes the pointed ticket, I'm not really common with Zsh internals. But I can see that at least mc's precmd function appears to be executed last in list.

comment:2 Changed 3 years ago by andrew_b

  • Keywords patch removed
  • Status changed from new to accepted
  • Votes for changeset set to andrew_b
  • Owner set to andrew_b
  • Branch state changed from no branch to on review

comment:3 Changed 3 years ago by andrew_b

  • Blocking 3121 added

comment:4 Changed 3 years ago by slavazanko

  • Votes for changeset changed from andrew_b to andrew_b slavazanko
  • Branch state changed from on review to approved

comment:5 Changed 3 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b slavazanko to committed-master
  • Resolution set to fixed
  • Blocking 3121 removed
  • Branch state changed from approved to merged

comment:6 Changed 3 years ago by andrew_b

  • Status changed from testing to closed

comment:7 Changed 3 years ago by egmont

It's broken, see #3177 for fix.

comment:8 Changed 3 years ago by gotar

  • Cc gotar@… added
Note: See TracTickets for help on using tickets.