Ticket #3064 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

mc crashes on rpm packages with tar files inside

Reported by: dsilakov Owned by: andrew_b
Priority: major Milestone: 4.8.11
Component: mc-vfs Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

MC always expects to see CPIO content inside RPM packages. However, it is also possible for RPM packages to contain TAR payload (ustar, to be more precise).

You can find an example of such rpm here - http://bugs.rosalinux.ru/show_bug.cgi?id=2612

When trying to open such package, mc crashes.

The fix is rather simple, since rpm2cpio works correctly for such files (but it produces tar archives, not cpio ones).

Attachments

mc-4.8.10-rpm-ustar-payload.patch (1.2 KB) - added by dsilakov 4 years ago.
Patch against mc-4.8.10 to add support for rpms with ustar payload

Change History

Changed 4 years ago by dsilakov

Patch against mc-4.8.10 to add support for rpms with ustar payload

comment:1 Changed 4 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Milestone changed from Future Releases to 4.8.11

Branch: 3064_crash_rpm_with_tar.
Initial changeset:be2d017fe781f457411988b705c664fa10d24b25
The proposed patch is applied as 2nd commit in this branch.

comment:2 Changed 4 years ago by andrew_b

  • Branch state changed from no branch to on review

comment:3 Changed 4 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:4 Changed 4 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • Branch state changed from on review to approved

comment:5 Changed 4 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko angel_il to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

comment:6 Changed 4 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.