Ticket #305 (closed defect: fixed)
Extra character on renaming
| Reported by: | styx | Owned by: | slavazanko |
|---|---|---|---|
| Priority: | major | Milestone: | 4.7 |
| Component: | mc-core | Version: | master |
| Keywords: | commited-master | Cc: | |
| Blocked By: | Blocking: | ||
| Branch state: | Votes for changeset: |
Description
When you try to rename a file with name:
????? ?㤥?.avi, where 㤥 == 0xE3, you will have an extra character in the end of name. I'he got '.' (dot). If you remove (just) character 0xE3 the extra character also becomes removed.
Attachments
Change History
comment:3 Changed 15 years ago by styx
I have new test case which fails:
- Create file with name '악마 탱크.txt' and try to rename
P.S. File can be deleted freely. Lang=Korean
comment:4 Changed 15 years ago by slavazanko
- Keywords review added
- Owner set to slavazanko
- Status changed from new to accepted
branch 305_utf8_renaming created (parent: master)
initial commit: changeset:8573660278d5fada596ee92ebe94dcbcbe697054
Review.
comment:7 Changed 15 years ago by angel_il
- Keywords vote-angel_il added
for test
touch х
f5/f6 without this patch not work.
f5/f6 with patch work correct.
Changed 15 years ago by angel_il
- Attachment 0001-Ticket-305-dont-work-rename-copy-on-some-chars.patch added
rebased on current master
comment:8 Changed 15 years ago by slavazanko
- Keywords vote-angel_il removed
- Version changed from 4.6.2 to master
- Blocked By 340 removed
created branch 305_extra_character_on_renaming (parent: master)
Initial: changeset:60f329401c1775ce392ea4587844b01cad71030a
Previous branch '305_utf8_renaming' was deleted.
review&vote.
comment:10 follow-up: ↓ 11 Changed 15 years ago by iNode
Does not work for me.
Without shell Patterns on, and regex pattern "^\(.*\)$"
With shell Patterns on, pattern "*", result files hash bad names.
i.e. for test defined below is:
$ ls | less <D1> <EC><95>
Yes, it's that branch:
$ mc -V | grep GNU GNU Midnight Commander 4.6.99.2-53-g60f3294
Test description:
#!/bin/sh rm -f *.tst touch хтест.tst 악마탱크.tst cat<<DESCRIPTION === test #305 === now try to move or copy all tst files if it is - all ok (press enter to close test description) DESCRIPTION read void
Configured with --enable-charset --enable-extcharset --enable-background
comment:11 in reply to: ↑ 10 Changed 15 years ago by iNode
Also my locale settings
$ locale LANG=ru_RU.UTF-8 LC_CTYPE="ru_RU.UTF-8" LC_NUMERIC="ru_RU.UTF-8" LC_TIME="ru_RU.UTF-8" LC_COLLATE="ru_RU.UTF-8" LC_MONETARY="ru_RU.UTF-8" LC_MESSAGES=POSIX LC_PAPER="ru_RU.UTF-8" LC_NAME="ru_RU.UTF-8" LC_ADDRESS="ru_RU.UTF-8" LC_TELEPHONE="ru_RU.UTF-8" LC_MEASUREMENT="ru_RU.UTF-8" LC_IDENTIFICATION="ru_RU.UTF-8"
comment:12 Changed 15 years ago by slavazanko
- Keywords rework added; review vote-angel_il removed
Yepp, bug present
comment:13 Changed 15 years ago by slavazanko
- Keywords review added; rework removed
If used glib-regex, then bug was present. Now fixed. Review, please.
comment:16 Changed 15 years ago by slavazanko
- Status changed from accepted to testing
- Keywords commited-master added; vote-andrew_b vote-slyfox approved removed
- Resolution set to fixed
Commit changeset:8e5cc41da1efe6422daa58f47350ebbf04318642
changes:
git diff 22ca1a9263d7...8e5cc41da1efe6422
oh, it's not 0xE3 it is 0x3925
it's should be utf-8 stuff