Ticket #2873 (closed defect: fixed)

Opened 7 years ago

Last modified 6 years ago

diffviewer cannot open file if name contains '$'

Reported by: szaszg Owned by: andrew_b
Priority: major Milestone: 4.8.6
Component: mcdiff Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master committed-stable

Description

In some cases mcdiff fail to open files if name contain '$':

Reproduce:

  • one panel:tes$t.txt
  • other panel: some other file
  • press Ctrl + x + d

mcdiff error message: [Two files are needed to compare]
and a message in the command line (stderr?): "diff: /home/gergely/tes.txt: No such file or directory"

If filename is test$.txt then everithing is O.K. !!!

Change History

comment:1 Changed 7 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Keywords stable-candidate added
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.5

Branch: 2873_diff_escape_dollar (parent: master).
Initial changeset:3bd09a019262b943e075e5d377c09f931fd1966c
Last changeset 2873_diff_escape_dollar

Last edited 7 years ago by angel_il (previous) (diff)

comment:2 Changed 7 years ago by andrew_b

  • Branch state changed from on review to no branch

comment:3 Changed 7 years ago by andrew_b

  • Branch state changed from no branch to on review

comment:4 Changed 7 years ago by angel_il

  • Votes for changeset set to angel_il

comment:5 Changed 7 years ago by slavazanko

  • Votes for changeset changed from angel_il to angel_il slavazanko
  • Branch state changed from on review to approved

comment:6 Changed 7 years ago by andrew_b

  • Keywords stable-candidate removed
  • Status changed from accepted to testing
  • Votes for changeset changed from angel_il slavazanko to committed-master committed-stable
  • Resolution set to fixed

Merged to master: [68bc12ff650d322959abcc596cbe816e3e82213a].

git log --pretty=oneline ad44cd1..68bc12f

Merged to 4.8.1-stable: [ac3cec8479d909db3e3fb2d1a35aca79703ddf8a].

git log --pretty=oneline e959b5a..75a19e2

comment:7 Changed 7 years ago by andrew_b

  • Status changed from testing to closed

comment:8 Changed 7 years ago by andrew_b

  • Milestone changed from 4.8.5 to 4.8.6

comment:9 Changed 6 years ago by andrew_b

  • Branch state changed from approved to merged
Note: See TracTickets for help on using tickets.