Ticket #2768 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

tests/.../do_panel_cd.c test fails when $HOME contains trailing '/'

Reported by: slyfox Owned by: slyfox
Priority: major Milestone: 4.8.3
Component: tests Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master committed-stable

Description

Steps to reproduce:

$ HOME=${HOME}/ make check
Running suite(s): /src/filemanager
cwd=/subvolumes/var_tmp/paludis/app-misc-mc-9999/temp
mc_config_get_home_dir ()=/subvolumes/var_tmp/paludis/app-misc-mc-9999/temp/
0%: Checks: 1, Failures: 1, Errors: 0
do_panel_cd.c:86:F:Core:test_do_panel_cd_empty_mean_home:0: Assertion 'ret' failed

My package manager appends that trailing '/' when builds package in sandboxed environment.

Change History

comment:1 Changed 10 years ago by slyfox

  • Owner set to slyfox
  • Status changed from new to accepted
  • Branch state changed from no branch to on review

Added path normalization by using vfs facility.
Is it correct way to do it? :]

Pushed as branch:2768_do_panel_cd_fix

Please review.

Last edited 10 years ago by angel_il (previous) (diff)

comment:2 Changed 10 years ago by angel_il

  • Votes for changeset set to angel_il

comment:3 Changed 10 years ago by slavazanko

  • Votes for changeset changed from angel_il to angel_il slavazanko
  • Branch state changed from on review to approved

comment:4 Changed 10 years ago by andrew_b

  • Milestone changed from Future Releases to 4.8.3

comment:5 Changed 10 years ago by slyfox

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:6 Changed 10 years ago by slyfox

  • Votes for changeset changed from angel_il slavazanko to committed-master
  • Branch state changed from approved to merged

comment:7 Changed 10 years ago by andrew_b

  • Keywords stable-candidate added

comment:8 Changed 10 years ago by andrew_b

  • Status changed from testing to closed
  • Keywords stable-candidate removed
  • Votes for changeset changed from committed-master to committed-master committed-stable

Cherry-picked to 4.8.1-stable: [c8e584dead265dbd62497342361a8151c581c2c2]

Note: See TracTickets for help on using tickets.