Ticket #275 (closed defect: fixed)
External panelize no have exit point
| Reported by: | angel_il | Owned by: | angel_il |
|---|---|---|---|
| Priority: | minor | Milestone: | 4.8.1 |
| Component: | mc-core | Version: | master |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | merged | Votes for changeset: | committed-master |
Description (last modified by angel_il) (diff)
External panelize no have exit point ".." to leave panelize.
in mc:
$ mkdir /tmp/test1
$ cd /tmp/test1
$ touch test.txt
click menu:
Command / eXternal panelize
select:
Field "Command"
input ls
click [ Add new ]
in field
Enter command label:
input ls
click [< OK >]
click menu:
Command / eXternal panelize
select ls in list
click [< Panelize >]
in current panel you have "test.txt"
and not ".." to exit from this list.
also panelize must be more friendly and intuitive.
Attachments
Change History
comment:2 Changed 16 years ago by angel_il
- Status changed from new to accepted
- Owner set to angel_il
Changed 16 years ago by angel_il
- Attachment 0001-add-exit-point-from-panelized-filter-.-in-top-list.patch added
comment:6 follow-up: ↓ 7 Changed 16 years ago by kdave
There is no need for the ".." entry, just press Ctrl-R to refresh the panel and you will get back.
Changed 16 years ago by angel_il
- Attachment 0001-add-exit-point-to-panelized-filter-in-top-list.patch added
comment:7 in reply to: ↑ 6 Changed 16 years ago by angel_il
- Keywords review added; rework removed
Replying to kdave:
There is no need for the ".." entry, just press Ctrl-R to refresh the panel and you will get back.
Ok, but need for this :) ctrl-r is intuitive feature. I think is any one directory list must have exit point.
comment:8 Changed 16 years ago by slavazanko
There is no need for the ".." entry, just press Ctrl-R to refresh the panel and you will get back
IMHO this bad behavior.
For example: if I'll create external panelize filter with:
grep -R -I ' gg_free (' ./ | cut -d : -f 1| sort|uniq
This filter show all files contain call of 'gg_free' function. For example, this is an error and need to fix. I'll fix this file-by-file in panelize ('gg_free' => 'g_free'). Then I'll press CTRL+R and I want to refresh list of filtered files. This more sense for CTRL+R operation (refresh content). Why CTRL+R must exit from panelize view?
BTW, is possible to change header of panel if panelized used?
For example, my current dir is /srv/work/mc/git if I try to panelize by 'ls *.in' command, I see at top of panel '/srv/work/mc/git' and only '*.in' files. IMHO, better to see ex.panel: ls *.in at top of panel.
comment:9 Changed 16 years ago by angel_il
fix: Ok, but need for this :) ctrl-r is NOT intuitive feature.
comment:13 Changed 16 years ago by angel_il
- Status changed from accepted to testing
- Keywords commited-master added; approved removed
- Resolution set to fixed
comment:16 Changed 13 years ago by angel_il
- Status changed from closed to reopened
- Version changed from 4.6.2 to master
- Branch state set to on review
- Milestone set to 4.8
- Keywords panelize added; vote-slavazanko vote-andrew_b commited-master removed
- Resolution fixed deleted
branch: 275_panelize_enhacement
please review
comment:19 Changed 13 years ago by slavazanko
- Votes for changeset changed from iNode to iNode slavazanko
- Branch state changed from on review to approved
comment:20 Changed 13 years ago by slavazanko
- Branch state changed from approved to on hold
On hold until 4.8.0 release
comment:21 Changed 13 years ago by angel_il
- Status changed from reopened to closed
- Votes for changeset iNode slavazanko deleted
- Resolution set to fixed
- Branch state changed from on hold to merged
comment:22 Changed 13 years ago by andrew_b
- Keywords panelize removed
- Status changed from closed to reopened
- Resolution fixed deleted
- Branch state changed from merged to no branch
The 'File listing' menu entry doesn't return panel from panelize mode to file listing one.
comment:23 Changed 13 years ago by andrew_b
- Milestone changed from 4.8 to 4.8.1
Branch: 275_panelization_fixes (parent: master).
Initial changeset:3dbc61124f1d14f86f0f616598bb55edd6527b7f
comment:25 Changed 13 years ago by angel_il
- Branch state changed from no branch to on review
please review
comment:27 Changed 13 years ago by slavazanko
- Votes for changeset changed from andrew_b to andrew_b slavazanko
- Branch state changed from on review to approved
comment:28 Changed 13 years ago by angel_il
- Status changed from accepted to testing
- Resolution set to fixed
comment:29 Changed 13 years ago by angel_il
- Status changed from testing to closed
- Branch state changed from approved to merged
comment:30 Changed 13 years ago by angel_il
- Votes for changeset changed from andrew_b slavazanko to committed-master
