Ticket #2514 (closed defect: fixed)

Opened 14 years ago

Last modified 14 years ago

Skip localized hints files installation when built with --disable-nls

Reported by: fjoe Owned by: andrew_b
Priority: minor Milestone: 4.8.0-pre1
Component: mc-core Version: 4.7.5
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

Localized hints files are installed regardless of --disable-nls configure option.
Attached patch fixes this.

Attachments

patch-without-nls​ (896 bytes) - added by fjoe 14 years ago.
Omit localized hints files installation if configured with --disable-nls

Change History

Changed 14 years ago by fjoe

Omit localized hints files installation if configured with --disable-nls

comment:1 Changed 14 years ago by andrew_b

  • Status changed from new to accepted
  • severity changed from no branch to on review
  • Priority changed from major to minor
  • Owner set to andrew_b
  • Milestone changed from 4.8 to 4.8.0-pre1
  • Keywords stable-candidate added

Unfortunately, your patch is not quite correct. With this patch, if you build mc with --disable-nls option and then create the distribute tarball with source code, that tarball doesn't contain language-specific hints.

In addition to the ticket subject, I think, other multi-language stuff (man pages and help file) also should not be installed.

Created 2514_disable_nls branch (parent: master).
changeset:892f82ec6c1edeb029c815bc8cf301cfa94121f8

comment:2 Changed 14 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:3 Changed 14 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • severity changed from on review to approved

comment:4 Changed 14 years ago by andrew_b

  • Status changed from accepted to testing
  • Component changed from translations to mc-core
  • Votes for changeset changed from slavazanko angel_il to committed-master
  • Resolution set to fixed
  • severity changed from approved to merged

Merged to master.
changeset:80c2334e149f0c84be0fde5ce7d0491812f51beb

comment:5 Changed 14 years ago by andrew_b

  • Keywords stable-candidate removed
  • Status changed from testing to closed

Cherry-picked to 4.7.5-stable.
changeset:1be8e136e999c4ce2efbc4216c425cb7a121336c

Note: See TracTickets for help on using tickets.