Ticket #2501 (closed task: fixed)

Opened 14 years ago

Last modified 14 years ago

sources in 'lib' directory should be independ to sources in 'src' directory

Reported by: slavazanko Owned by: andrew_b
Priority: major Milestone: 4.8.0-pre1
Component: mc-vfs Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

Sources from 'lib' subdirectory have lot functions calls in 'src' subdirectory (and have lot of #include's from 'src'). Need to split 'lib' and 'src' for possibility of unit tests and propably for future plugins.
Also, initial support for unit tests is needed (see ​http://check.sourceforge.net/)

Change History

comment:1 Changed 14 years ago by slavazanko

  • Owner set to slavazanko
  • Status changed from new to accepted
  • severity changed from no branch to on review
  • Milestone changed from 4.8 to 4.8.0-pre1

Created branch 2501_split_lib
changeset: ​2501_split_lib

Review, please

Last edited 14 years ago by angel_il (previous) (diff)

comment:2 Changed 14 years ago by birdie

  • Summary changed from 'lib' should be independ to 'src' directory to 'lib' directory sources should not depend on the 'src' directory

A little bit of love for English won't hurt.

comment:3 Changed 14 years ago by slavazanko

  • Summary changed from 'lib' directory sources should not depend on the 'src' directory to sources in 'lib' directory should be independ to sources in 'src' directory

comment:4 Changed 14 years ago by andrew_b

  • Votes for changeset set to andrew_b

comment:5 Changed 14 years ago by angel_il

  • Votes for changeset changed from andrew_b to andrew_b angel_il
  • severity changed from on review to approved

comment:6 Changed 14 years ago by slavazanko

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b angel_il to committed-master
  • Resolution set to fixed
  • severity changed from approved to merged

merge changeset:30bc575179f8a7c3a1d0abb3fa3390916d7354e0

git log --pretty=oneline b67d0c0..9942549

comment:7 Changed 14 years ago by slavazanko

  • Status changed from testing to closed

comment:8 Changed 14 years ago by andrew_b

  • Status changed from closed to reopened
  • Votes for changeset committed-master deleted
  • severity changed from merged to on review
  • Component changed from mc-core to mc-vfs
  • Version changed from 4.7.5 to master
  • Resolution fixed deleted

Lets continue split of VFS core library and vfs plugins.

Branch:2501_vfs_split. Parent: master.
Initial changeset:cf9c6466d29b8af01c4c11b6eda5cd9f55cfb006

comment:9 Changed 14 years ago by angel_il

  • Votes for changeset set to angel_il

comment:10 Changed 14 years ago by slavazanko

  • Votes for changeset changed from angel_il to angel_il slavazanko
  • severity changed from on review to approved

comment:11 Changed 14 years ago by andrew_b

  • Owner changed from slavazanko to andrew_b
  • Status changed from reopened to accepted

comment:12 Changed 14 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from angel_il slavazanko to committed-master
  • Resolution set to fixed
  • severity changed from approved to merged

Merged to master.
changeset:c18564dcf57a69ccce7d6e48c900a653e4d73c66

git log --pretty=oneline 6b09134..c18564d

comment:13 Changed 14 years ago by andrew_b

  • Status changed from testing to closed

comment:14 Changed 14 years ago by andrew_b

#2535 (changeset:1796c8536a6c6d1d06c90bfcb1c268c83d171bb1) fixes the segfault in FTP VFS.

Note: See TracTickets for help on using tickets.