mcedit text selection length doesn't change when text is deleted

[jimklimov]

When some text is selected in MCEDIT (via ESC+3 and arrow keys and selection is fixed by pressing ESC+3 again), and then some of the selection text is removed by backspace key only, and then the text is subsequently saved (ESC+2), the end of selection "moves forward" by the amount of characters removed by backspace.

This is best seen when several whole lines are initially selected, and some characters are removed in the middle of selection. After saving the file, end of selection becomes a few characters into the next line after old end of selection.

This does not happen when selection characters removed by DEL or Ctrl+D keys, nor when whole lines are removed by Ctrl+Y.

This does not happen when characters are added inside the selection.

This does happen when some characters are backspaced away and the same amount of characters is typed inside the selection.

Occurence by versions:

• tested positive in 4.7.4, 4.7.0.10;
• tested negative in old 4.6.1

[angel_il]

steps to reproduce
text

11111
22222
33333
44444
55555

1) switch on Persistent selection ([х] Persistent selection)
2) select text from 2 to 4 lines
3) move cursor into end of line №3
4) delete 3 chars with backspace
5) move cursor into line 5

[angel_il]

branch: 2437_editor_selection_length_fix
changeset: 951eb0882d943fe70027d307918be9810fb9470f

please review

[gotar]

See also #2394.

[jimklimov]

+1
fixes the problem for 4.7.0.10-based source

[andrew_b]

Replying to gotar:

See also #2394.

What do you mean? Does this fix also fixes #2394 fully or partially?

[slavazanko]

Comitted in master, merge changeset:13ee4df7146c95acbfdcd9aa6e886a5057ca315a

[andrew_b]

Cherry-picked into 4.7.0-stable.
changeset:ef6aa67e65d2d9cc628eafbd47a476ecc88a53a0