Ticket #2305 (closed defect: fixed)
permission_mode setting from 4.7.2 config ignored
| Reported by: | gotar | Owned by: | andrew_b |
|---|---|---|---|
| Priority: | minor | Milestone: | 4.8.0-pre1 |
| Component: | mc-core | Version: | master |
| Keywords: | Cc: | zaytsev | |
| Blocked By: | Blocking: | ||
| Branch state: | Votes for changeset: | committed-master |
Description
I've got:
[Layout]
permission_mode=1
After upgrading to 4.7.3 this setting was ignored. I've found 2b167cbef0bca2db3d5dbb2798f9ddae5389eddd and 8fd0771e38cbac22299c4934592bbd8fc0326732 but apparently they refer to main config section [Midnight-Commander] instead of layout (http://www.midnight-commander.org/browser/src/setup.c?rev=0400e92fc5bcc6fd0e287505d8ac82ff706a79e2). After saving the new setup I see:
[Midnight-Commander]
permission_mode=0
[Panels]
permission_mode=false
Change History
comment:1 in reply to: ↑ description ; follow-up: ↓ 2 Changed 14 years ago by andrew_b
- Status changed from new to accepted
- Owner set to andrew_b
- Component changed from mc-config-ini to mc-core
comment:2 in reply to: ↑ 1 ; follow-up: ↓ 3 Changed 14 years ago by gotar
Replying to andrew_b:
[Layout]
permission_mode=1
This is old location.
Yes, I know that. It just should be somehow read from [Layout] (too) not [M-C] (only).
[Midnight-Commander]
permission_mode=0
This is buggy implementation of backward compatibility. I think, we can just drop the backward compatibility for global panels options because it will make the panel option loading and saving more simple.
I see no reason for backward compatibility when saving, but loading should always work.
comment:3 in reply to: ↑ 2 Changed 14 years ago by andrew_b
Replying to gotar:
but loading should always work.
Actually, since mc is being developed, we cannot provide the whole backward compatibility with previous versions. From time to time we have drop it partially. MC is released not so often and users no need to tune its settings after each MC upgrade.
comment:4 follow-up: ↓ 6 Changed 14 years ago by zaytsev
Drop when saving = YES!!!
Drop when loading = NO :(
mc is released almost every month. This *is* often. Right now I mostly kill .mc when I have to switch between versions, this is not so cool :(
comment:8 Changed 14 years ago by andrew_b
- Status changed from accepted to testing
- Version 4.7.3 deleted
- Resolution set to wontfix
- Milestone 4.7 deleted
comment:10 Changed 14 years ago by andrew_b
- Status changed from closed to reopened
- Version set to master
- Resolution wontfix deleted
- Milestone set to 4.7
Created 2305_permission_mode branch. Parent branch is master.
changeset:90288a9a8bc4b274c8b115051d0d3453c0a0e847
comment:11 Changed 14 years ago by andrew_b
- Priority changed from trivial to minor
- severity changed from no branch to on review
- Milestone changed from 4.7 to 4.8.0-pre1
I think 4.8 release is a good point to drop some old options, especially after #1851.
Created new branch 2305_drop_panel_old_options (parent: master).
Initial changeeset:543f92fb44a1731a8094b7cea66e54858815e234
comment:12 Changed 14 years ago by andrew_b
comment:14 Changed 14 years ago by angel_il
- Votes for changeset changed from slavazanko to slavazanko angel_il
- severity changed from on review to approved
comment:15 Changed 14 years ago by andrew_b
- Keywords stable-candidate added
- Status changed from reopened to closed
- Votes for changeset changed from slavazanko angel_il to committed-master
- Resolution set to fixed
- severity changed from approved to merged
Merged to master.
changeset:22cdf545f4d246382213a5eaa6106f4774a8c753
git log --pretty=oneline 69d66dd..22cdf54
Replying to gotar:
This is old location.
This is buggy implementation of backward compatibility. I think, we can just drop the backward compatibility for global panels options because it will make the panel option loading and saving more simple.
This is current location.