mcview: incorrect starting offset for 'search again'

[egmont]

When you press F7 in mcview to repeat the previous search, it starts again from the file offset that is 3 bytes after the beginning of the current match. This introduces weird and clearly buggy symptoms. Couple of examples:

If the file contains

xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

and you search for a single x character, and you keep on pressing F7, every third character gets highlighted.

If, in the same file, you search for xxxxxxxxxxxxx (many, but way fewer x characters than in the file), the matching window keeps on moving by 3 characters.

If the file contains

xyxyxyxyxyxyxyxyxyxyxyxy

and you search for xy, you get every second match.

If the file is a shell script with comments, such at this:

#!/bin/bash
# 
# copyright stuff
#
# blah

and you search for # then the ones after the empty comment lines are skipped.

Advancing by 3 bytes is totally arbitrary and leads to buggy behavior. Either you should advance by 1 byte, or advance to the end of the previous match (these would behave differently, IMHO both of them make sense).

[egmont]

fix with minor side effects (see comment)

[egmont]

Attached patch fixes the problem, while resurrects ticket #265.

Until a permanent solution is created by someone, I recommend applying this patch, marking this bug as fixed and reopening #265. I think it's better to have duplicate matches in a rare use case rather than missing some matches in a more common use case.

[slavazanko]

Created branch 2294_viewer_search_offset

Initial changeset:899bcae078f2dfc82182b05268c4c691a467220b

Review, please.

I think it's better to have duplicate matches in a rare use case rather than missing some matches in a more common use case.

You right, after resolve this issue #265 will be reopened.

[slavazanko]

Merge changeset:becd744bb664ea0b7c6ffeef99113ea851cdc695

For getting list of commits type:

git log --pretty=oneline 906f688..3ad5f51

[slavazanko]

Cherry-picked in stable:

git log --pretty=oneline 52047442..a1cc8f37e