Ticket #2271 (closed defect: fixed)

Opened 7 years ago

Last modified 4 years ago

bogus string in confirmation config dialog

Reported by: ossi Owned by: andrew_b
Priority: minor Milestone: 4.8.11
Component: mc-core Version: 4.8.7
Keywords: Cc: zaytsev, egmont@…
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

f9 -> o -> o

i18n context information seems to have trickled into the user-visible description strings of the checkboxes.

Change History

comment:1 Changed 7 years ago by zaytsev

  • Cc zaytsev added

I don't see anything abnormal here on master (en_US locale). If you are talking about the "confirm" words that got removed, this happened long time ago (2a8817b9be4ed5b1a649cca164e2e53de34c7906) and seemingly on purpose.

comment:2 Changed 7 years ago by ossi

bravo, you got the right commit. though a bit differently than you thought ... ;)

i'm talking about the "Confirmation|" prefixes. they actually show up here.
maybe that's because i'm building with --disable-nls.
typically, i18n context information would be supplied as a separate parameter to the function/macro. that wouldn't rely on some string mangling magic being built into gettext ...

i've seen this problem in some more places, but i couldn't find any of them right now. maybe it was fixed meanwhile or they are more hidden than i remembered.

comment:3 Changed 7 years ago by zaytsev

  • Owner set to andrew_b
  • Status changed from new to assigned

The fact that you used non-default ./configure parameters was crucial. Yes, this is yet unfixed remnant from the time, the prefixes were introduces (earlier same issue was fixed for copy/move dialogs).

comment:4 Changed 7 years ago by zaytsev

  • Milestone changed from 4.7 to 4.7.4

comment:5 Changed 7 years ago by andrew_b

  • Keywords stable-candidate added
  • severity changed from no branch to on review

Created 2271_confirmation_dialog_i18n branch. Parent branch is master.
changeset:95fc5e37d3dc0acfbf610e35da0d40fcff480f07

comment:6 Changed 7 years ago by zaytsev

  • Votes for changeset set to zaytsev

comment:7 Changed 7 years ago by slavazanko

  • Votes for changeset changed from zaytsev to zaytsev slavazanko
  • severity changed from on review to approved

comment:8 Changed 7 years ago by andrew_b

  • Keywords stable-candidate removed
  • Status changed from assigned to testing
  • Votes for changeset changed from zaytsev slavazanko to committed-master committed-stable
  • Resolution set to fixed
  • severity changed from approved to merged

Merged to master.
changeset:502a28d79af50208cfe0225c5c986e2377fa5cd4

Cherry-picked to 4.7.0-stable.
chamgeset:9cab5aaa890dbb51225a6b1da08e6a4f594b063a

comment:9 Changed 7 years ago by andrew_b

  • Status changed from testing to closed

comment:10 Changed 4 years ago by egmont

  • Status changed from closed to reopened
  • Cc egmont@… added
  • Version changed from master to 4.8.7
  • Branch state set to no branch
  • Milestone changed from 4.7.4 to 4.8.11
  • Resolution fixed deleted

This is buggy again since 4.8.7.

comment:11 Changed 4 years ago by andrew_b

  • Votes for changeset committed-master committed-stable deleted
  • Branch state changed from no branch to on review

Branch: 2271_confirmation_dialog_i18n
changeset:f7e12a620da44b89ab083bb012d743d172307c82

comment:12 Changed 4 years ago by egmont

Thanks! :)

comment:13 Changed 4 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:14 Changed 4 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • Branch state changed from on review to approved

comment:15 Changed 4 years ago by andrew_b

  • Status changed from reopened to closed
  • Votes for changeset changed from slavazanko angel_il to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged
Note: See TracTickets for help on using tickets.