Ticket #207 (closed defect: fixed)
Minor regex fixes
| Reported by: | Patrick Winnertz <winnie@…> | Owned by: | winnie |
|---|---|---|---|
| Priority: | major | Milestone: | 4.6.2 |
| Component: | mc-core | Version: | 4.6.1 |
| Keywords: | vote-slavazanko vote-slyfox approved commited-master commited-mc-4.6 | Cc: | |
| Blocked By: | Blocking: | ||
| Branch state: | Votes for changeset: |
Description (last modified by winnie) (diff)
Hey,
There are smaller errors in the regex code of mc, the patches attached here
will fix this issues.
Please review and vote! :)
Attachments
Change History
Changed 15 years ago by Patrick Winnertz
- Attachment 99a_fix-regex-bol-match.patch added
comment:2 Changed 15 years ago by Patrick Winnertz
- Owner set to winnie
- Status changed from new to accepted
- Milestone changed from 4.7 to 4.6.2
This should also be fixed in 4.6.2. Therefore I created a branch called:
207_minor_regex_fixes.
Please review and vote!
Greetings
comment:5 Changed 15 years ago by slyfox
- Keywords vote-slyfox approved added; review removed
99c_fix-regex-newline-match.patch
Changes regex subst behaviour for following example:
regex: s,3$,TEST,
file_to_edit:
1 2 3 1 2 3 1 2 3
When patch applied all the 3 are substituted, without the patch - only the last occurence. So patch is clearly a Good Thing :]
99a_fix-regex-bol-match.patch
Nothing looks broken, but I could not figure an example to test this change. Could you provide one?
My vote is yours :]
Note: See
TracTickets for help on using
tickets.
Added by email2trac