Ticket #2053 (accepted defect) — at Version 1

Opened 14 years ago

Last modified 14 years ago

lib-vfs-mc-vfs-vfs.c-mc_symlink-missing-g_free

Reported by: vit_r Owned by: andrew_b
Priority: major Milestone: 4.7.1
Component: mc-vfs Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description (last modified by andrew_b) (diff)

when a try to bring this old fashion style 

    mpath = ...
    if (mpath != NULL) {
    vfs = vfs_get_class (mpath);
    result = vfs->setctl ? (...) : 0;
    g_free (mpath);
    return result;
    } else return -1;

to currently (for mc) looking like

    mpath = ...
    if (mpath == NULL)
	return -1;
	
    vfs = vfs_get_class (mpath);
    result = vfs->setctl ? (...) : 0;
    g_free (mpath);
    return result;

this missing g_free() popped up



Change History

Changed 14 years ago by vit_r

comment:1 Changed 14 years ago by andrew_b

  • Status changed from new to accepted
  • Description modified (diff)
  • Priority changed from trivial to major
  • Milestone changed from 4.7 to 4.7.1
  • Owner set to andrew_b
  • severity changed from no branch to on review

Created 2053_vfs_memleak branch. Parent branch is master.
changeset:37aee9a69aaf19bce9296f5cbe8e3dc93d815a9f

Note: See TracTickets for help on using tickets.