Ticket #2018 (closed defect: fixed)

Opened 15 years ago

Last modified 15 years ago

FTPFS: strcpy() is used for overlaping strings

Reported by: andrew_b Owned by: andrew_b
Priority: major Milestone: 4.7.1
Component: mc-vfs Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master committed-stable

Description (last modified by andrew_b) (diff)

There is a following code in lib/vfs/mc-vfs/ftpfs.c file:

220         /* replace first occurance of ":/" with ":" */
221         if ((p = strchr (ret, ':')) && *(p + 1) == '/')
222             strcpy (p + 1, p + 2);

But strcpy() must not be used for overlaping objects.

Change History

comment:1 Changed 15 years ago by andrew_b

  • severity changed from no branch to on review
  • Description modified (diff)

Created 2018_fptfs_strcpy branch. Parent branch is master.
changeset:1fa19b8f818dd11b5e0df5187e26d911dcb3bef7

comment:2 Changed 15 years ago by angel_il

  • Votes for changeset set to angel_il

comment:3 Changed 15 years ago by slavazanko

  • Votes for changeset changed from angel_il to angel_il slavazanko
  • severity changed from on review to approved

comment:4 Changed 15 years ago by andrew_b

  • Status changed from new to closed
  • Votes for changeset changed from angel_il slavazanko to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

Merged to master.
changeset:68ecccb453d3d954924053741bf224c2a766d0ec

comment:5 Changed 15 years ago by andrew_b

  • Votes for changeset changed from commited-master to commited-master commited-stable

Cherry-picked to 4.7.0-stable.
changeset:f0628b8f05a81c5b4cf9cc53bbc862c82429b319

Note: See TracTickets for help on using tickets.