Ticket #1931 (closed defect: fixed)
VFS: fixup for no-vfs builds
Reported by: | metux | Owned by: | metux |
---|---|---|---|
Priority: | major | Milestone: | 4.7.1 |
Component: | mc-vfs | Version: | master |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Branch state: | Votes for changeset: | committed-master |
Change History
comment:1 Changed 15 years ago by metux
- Status changed from new to accepted
- severity changed from no branch to on review
- Description modified (diff)
comment:2 follow-up: ↓ 3 Changed 15 years ago by andrew_b
- Component changed from mc-core to mc-vfs
I belive that a lot of comits, realated to removed src/vfsdummy.h, can be sqaushed to single commit for easier review.
comment:3 in reply to: ↑ 2 ; follow-up: ↓ 4 Changed 15 years ago by metux
Replying to andrew_b:
I belive that a lot of comits, realated to removed src/vfsdummy.h, can be sqaushed to single commit for easier review.
I've did it this way for easier review ;-o
comment:4 in reply to: ↑ 3 ; follow-up: ↓ 5 Changed 15 years ago by andrew_b
Replying to metux:
I've did it this way for easier review ;-o
You move content of src/vfsdummy.h into vfs/vfs.h and then remove src/vfsdummy.h. I think it can be maken with single commit but not with 30 commits.
comment:5 in reply to: ↑ 4 ; follow-up: ↓ 6 Changed 15 years ago by metux
Replying to andrew_b:
Replying to metux:
I've did it this way for easier review ;-o
You move content of src/vfsdummy.h into vfs/vfs.h and then remove src/vfsdummy.h. I think it can be maken with single commit but not with 30 commits.
I did it this way, since I had been asked to do so.
Actually, if we've got some changes in vfsdummy.h before this branch is merged, we can catch it *much* easier (minimize the chance that somethings slips through).
We could squash'em together after approval, right before merge.
comment:6 in reply to: ↑ 5 Changed 15 years ago by andrew_b
- Votes for changeset set to andrew_b
- Milestone changed from 4.7 to 4.7.1
Replying to metux:
We could squash'em together after approval, right before merge.
OK, will not forget that.
comment:7 Changed 15 years ago by slavazanko
- Votes for changeset changed from andrew_b to andrew_b slavazanko
- severity changed from on review to approved
comment:8 Changed 15 years ago by andrew_b
- Status changed from accepted to testing
- Votes for changeset changed from andrew_b slavazanko to commited-master
- Resolution set to fixed
- severity changed from approved to merged
Merged to master.
git log --pretty=oneline 3e42f64..49c8644
comment:10 Changed 15 years ago by slavazanko
4.7.0-stable:
git diff 22d328f609f81ee07c414b45dd6b193f9a3ab1b7...8df60dac4f675bc4ead165f8daf1f4002506cd57