Ticket #188 (accepted enhancement) — at Version 5

Opened 16 years ago

Last modified 15 years ago

(mandriva) show free space

Reported by: metux Owned by: metux
Priority: major Milestone: 4.7
Component: mc-core Version: 4.6.2
Keywords: commited-master Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description (last modified by metux) (diff)

​http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/mc/current/SOURCES/mc-showfree.patch?view=markup

branch:188_show_free_space
changeset:059f076bce7eaa0396abc183631bfd7330595382

Change History

comment:1 Changed 16 years ago by metux

  • Type changed from defect to enhancement

comment:2 Changed 16 years ago by andrew_b

I've modified this patch (see attachment). Differences:

  • info format is changed from (as an example) "5M (50%) of 10M" to " 5M/10M (50%) ". So we don't need to translate it.
  • show_free_space() function is moved from main.c to screen.c. Now this function is called in show_dir() function only. Related global variables are moved into show_free_space() and made static.

But there is a problem as in Mandriva/RH patch as in mine one. The init_my_statfs() function is called many times, therefore we have the memory leak.

Changed 16 years ago by andrew_b

comment:3 Changed 16 years ago by metux

  • Owner set to metux
  • Keywords vote-metux added
  • Status changed from new to accepted
  • Description modified (diff)

comment:4 Changed 16 years ago by andrew_b

  • Version changed from 4.6.1 to 4.6.2

I fixed memory leak in init_my_statfs() function. Patch is attached. Please review.

Changed 16 years ago by andrew_b

Fix of memory leak in init_my_statsf()

comment:5 Changed 16 years ago by metux

  • Description modified (diff)
Note: See TracTickets for help on using tickets.