Ticket #1885 (closed defect: fixed)

Opened 8 years ago

Last modified 15 months ago

git autogen.sh requires cvs

Reported by: s01ja Owned by: andrew_b
Priority: major Milestone: 4.8.17
Component: mc-core Version: 4.7.0-pre4
Keywords: Cc: zaytsev
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

$git clone git://midnight-commander.org/git/mc.git
$cd mc
$./autogen.sh
autopoint: * cvs program not found
autopoint:
* Stop.

$autopoint
autopoint: * cvs program not found
autopoint:
* Stop.

$autopoint --version
/usr/bin/autopoint (GNU gettext-tools) 0.17
Copyright (C) 2002-2007 Free Software Foundation, Inc.

fix: comment
l39
l40
in ./autogen.sh

host: ubuntu (netbook)

Attachments

mc-git-autopoint.patch (4.1 KB) - added by s01ja 7 years ago.
patch allowing testing without cvs installed
mc-1885-autoreconf-usage.patch (2.8 KB) - added by and 15 months ago.

Change History

comment:1 Changed 8 years ago by s01ja

  • Summary changed from git autogen.sh requires cvs to update on configure

fix: install cvs

comment the autopoint files does NOT work

comment:2 Changed 8 years ago by s01ja

  • Summary changed from update on configure to git autogen.sh requires cvs

comment:3 in reply to: ↑ description Changed 8 years ago by andrew_b

Replying to s01ja:

fix: comment
l39
l40
in ./autogen.sh

Actually, there are 92 lines only in autogen.sh.

comment:4 Changed 8 years ago by slavazanko

  • Status changed from new to closed
  • Resolution set to invalid

cvs needs just for autopoint utility. This stuff was got from gettext (version 0.17 and newer). For older versions of gettext we put into 'maint' subdir original (and unchanged) autopoint script from 'gettext' package.

If you have newest version of gettext, then own maint/autopoint will not running - will used autopoint from your gettext installation. Therefore CVS requipment it's not a mc bug.

Changed 7 years ago by s01ja

patch allowing testing without cvs installed

comment:5 Changed 7 years ago by s01ja

  • Status changed from closed to reopened
  • Resolution invalid deleted

cannot help it: every time i setup a git snapshot i am forced to install two tools: git and cvs.
just to compile and see if a bug is worth to report :(
my hosts are slow eg to save energy.
the thing i noticed in 4.6 is fixed in the current version. (good job) so i used the time compiling cvs and mc to fix the entry point for future mc developers:

with the attached patch it is now possible to do
$ git clone git://midnight-commander.org/git/mc.git
## apply patch
$ patch -p0 < mc-git-autopoint.patch
$ cd mc
$ ./autogen.sh
$ ./configure
$ make
$ ./src/mc
on a clean csv free modern system

(should be noted in the readme/install somehow)

it would be VERY nice the next time i try the git the patch is not necessary anymore.

the somewhat verbose output should warn the translating developers and when csv is installed everything works as it did before

paludis --remove cvs

host: gentoo netbook

comment:6 Changed 7 years ago by zaytsev

  • Cc zaytsev added

Hi Slava! It seems that you are bulshitting us :) In my case cvs is required although I have latest gettext installed. It takes the version from maint anyway.

comment:7 Changed 7 years ago by zaytsev

Can we update our gettext stuff in general? Or drop it altogether? Pros, cons?

comment:8 Changed 7 years ago by slavazanko

  • Blocked By 2409 added

comment:9 Changed 7 years ago by slavazanko

  • Owner set to slavazanko
  • Status changed from reopened to accepted

comment:10 Changed 7 years ago by slavazanko

  • severity changed from no branch to on review
  • Blocked By 2409 removed
  • Milestone changed from 4.7 to 4.7.5

Created branch 1885_autopoint_without_cvs
Initial changeset:fc99cac4c254a78feb301159d343e3b19cbf23b9

Review, please.

comment:11 Changed 7 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:12 Changed 7 years ago by slavazanko

  • Votes for changeset slavazanko deleted

Sorry, have troubles in branch

comment:13 Changed 7 years ago by slavazanko

  • severity changed from on review to on rework

comment:14 Changed 7 years ago by slavazanko

  • Blocking 2409 added

comment:15 Changed 7 years ago by slavazanko

  • Blocking 2409 removed

comment:16 Changed 6 years ago by andrew_b

  • Branch state set to no branch
  • Milestone changed from 4.7.5 to Future Releases

comment:17 Changed 16 months ago by andrew_b

I think this bug is not actual since gettext-0.18.1, which was released in June 2010:
http://git.savannah.gnu.org/cgit/gettext.git/tree/NEWS#n319

The configure option --with-cvs is deprecated. The 'autopoint' program will
now use the 'git' program by default to compress its archive. If the
configure option --without-git is specified, 'autopoint' will not rely on
'git', but will instead rely on a locally installed a 3 MB large archive.

But mc required gettext >= 0.14.3. I think we can update this requirement up to 0.18.1.

comment:18 Changed 16 months ago by zaytsev-work

  • Milestone changed from Future Releases to 4.8.17

I've built the 4.8.16 release tarballs with gettext-0.19.7, therefore a newer autopoint is already used. I agree that we should bump minimally required gettext version to gettext-0.18.1 and delete the autopoint script from gettext-0.18.1 from maint/utils/autopoint.

comment:19 Changed 15 months ago by andrew_b

  • Owner changed from slavazanko to andrew_b
  • Priority changed from trivial to major

Branch: 1885_autopoint_without_cvs
changeset:81db94cbadab3f1443fe5436c2dd2e9454abf713

Review, please.

comment:20 Changed 15 months ago by and

Can we go a step further and reduce autogen.sh complexity by using autoreconf these days?

Changed 15 months ago by and

comment:21 Changed 15 months ago by zaytsev

Hmmmm, that's an interesting idea: instead of getting rid of autogen.sh completely, keep it, but throw away most of it and replace with autoreconf. I think this will improve the current situation, and we can think of removing the rest later if and when we get time. However, I would also throw away the test -f checks, autoreconf will take care of that wouldn't it?

comment:22 Changed 15 months ago by egmont

  • Votes for changeset set to egmont

gettext-0.18.1 is a tiny bit older than glib-2.26 which we already require, so sure, let's go for it if it makes life simpler.

comment:23 follow-up: ↓ 24 Changed 15 months ago by zaytsev

  • Votes for changeset changed from egmont to egmont zaytsev

I have adapted the patch by Andreas (you're a genius, man!), pushed it to this branch and Travis checks seems to pass. Andrew, what do you think about it?

comment:24 in reply to: ↑ 23 Changed 15 months ago by andrew_b

  • Branch state changed from no branch to approved

Replying to zaytsev:

Andrew, what do you think about it?

Approved.

comment:25 Changed 15 months ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from egmont zaytsev to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master:61bc352b624aa0532b4342f206747f99cab814bb

git log --pretty=oneline 23c00cf..61bc352

comment:26 Changed 15 months ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.