Ticket #1810 (closed defect: fixed)
Missed break in CK_Edit_Save_Mode command handler (edit/edit.c:3121).
| Reported by: | vit_r | Owned by: | andrew_b |
|---|---|---|---|
| Priority: | major | Milestone: | 4.7.0 |
| Component: | mcedit | Version: | 4.7.0-pre4 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | Votes for changeset: | committed-master |
Description
Attachments
Change History
comment:1 Changed 15 years ago by vit_r
i'm not sure about emacs because i'm not using it
A word of an emacs expert is needed
Vit
comment:2 follow-up: ↓ 3 Changed 15 years ago by andrew_b
- Summary changed from Alt-d_Date-hotkey. to Missed break in CK_Edit_Save_Mode command handler (edit/edit.c:3121).
We have user-defined keybindings engine. Default keybindings are not changed since 4.7.0-pre3.
Therefore, only patch for edit/edit.c can be applied. Thanks!
comment:3 in reply to: ↑ 2 ; follow-up: ↓ 4 Changed 15 years ago by vit_r
Replying to andrew_b:
We have user-defined keybindings engine. Default keybindings are not changed since 4.7.0-pre3.
Therefore, only patch for edit/edit.c can be applied. Thanks!
But what about Alt-d and what about emacs ?
Vit
comment:4 in reply to: ↑ 3 ; follow-up: ↓ 5 Changed 15 years ago by andrew_b
Replying to vit_r:
But what about Alt-d and what about emacs ?
Nothing. Current shortcuts are totally frozen. If you want change some of them, make it in your ~/.mc/mc.keymap config.
comment:5 in reply to: ↑ 4 ; follow-up: ↓ 6 Changed 15 years ago by vit_r
Replying to andrew_b:
Replying to vit_r:
But what about Alt-d and what about emacs ?
Nothing. Current shortcuts are totally frozen. If you want change some of them, make it in your ~/.mc/mc.keymap config.
Right then latter we'll see
One more (might be well known):
Seems case CK_Unmark: is not used (pitty). Will it be fixed?
comment:6 in reply to: ↑ 5 Changed 15 years ago by andrew_b
- Status changed from new to accepted
- Owner changed from vit_r to andrew_b
- Component changed from mc-core to mcedit
- severity changed from no branch to on review
- Milestone changed from 4.7 to 4.7.0
Replying to vit_r:
Seems case CK_Unmark: is not used (pitty). Will it be fixed?
Let it be as is.
Created 1810_edit_save_mode branch. Parent branch: master.
changeset:314aabd0b2109cbdaf323750baced8af352fcf43
comment:8 Changed 15 years ago by slavazanko
- Votes for changeset changed from angel_il to angel_il slavazanko
- severity changed from on review to approved
comment:9 Changed 15 years ago by andrew_b
- Status changed from accepted to testing
- Votes for changeset changed from angel_il slavazanko to commited-master
- Resolution set to fixed
- severity changed from approved to merged
Merged to master.
changeset:354b1844636607831c01cf73fb2c6cba0f6560db
