Ticket #1780 (accepted defect) — at Version 10
Remove own declaration of errno
| Reported by: | metux | Owned by: | metux |
|---|---|---|---|
| Priority: | major | Milestone: | 4.7.1 |
| Component: | mc-core | Version: | 4.7.0-pre4 |
| Keywords: | Cc: | ||
| Blocked By: | #1872 | Blocking: | |
| Branch state: | Votes for changeset: | metux |
Description (last modified by metux) (diff)
branch: 1780_remove_errno_decl
changeset:1780_remove_errno_decl
Change History
comment:1 Changed 15 years ago by metux
- Owner set to metux
- Status changed from new to accepted
- Description modified (diff)
- severity changed from no branch to on review
comment:2 Changed 15 years ago by slavazanko
Added commits:
- 4b730c24a0f41b2178e1c5d02d64f220d2f35714: Removing calls of strerror() function in mc-core
- b94fb331c3860004119179a289945ea774cb6db9: Removed calls to strerror() function from own libsamba implementation.
Please remember: own libsamba will dropped in near time (we will use libsmbclient instead)
Therefore no need to much changes in own deprecated code.
comment:4 Changed 15 years ago by metux
rebased to current master, running through testfarm
please review
comment:9 follow-up: ↓ 10 Changed 15 years ago by slavazanko
No need to often rebase.
- b3e5c4ca3262e5588a04e49309919483a2dac88c: removing own declaration of errno and strerror()
- 49f5893c15e12465940ca3ed16b75570bbdb6b64: Removing calls of strerror() function in mc-core
- 7393892f2a4037969b7baddfdc4816927f69320f: Removed calls to strerror() function from own libsamba implementation.
I'm made last patch, therefore review please.
comment:10 in reply to: ↑ 9 Changed 15 years ago by metux
- Votes for changeset set to metux
- Description modified (diff)
Replying to slavazanko:
No need to often rebase.
I'm rebasing all my branches when the origin (in this
case master) is updated. the rule is: keep as close
as possible. This prevents later merge conflicts.
As master changed, and there _WAS_ an conflict, i rebased again.
I'm now voting for your commits, you could do it for mine,
(count them together as one) and then wait for another one ...
