Ticket #1746 (closed defect: fixed)

Opened 15 years ago

Last modified 15 years ago

[patch] Setting "Use passive mode over proxy" is not remembered

Reported by: bilbo Owned by: bilbo
Priority: major Milestone: 4.7.0
Component: mc-core Version: 4.7.0-pre4
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

Setting of "Use passive mode over proxy" in Options -> Virtual FS is not remembered in config. Someone forgot to add a corresponding line to src/setup.c

Attached patch fixes this

Attachments

passive-proxy-fix.patch​ (621 bytes) - added by bilbo 15 years ago.
Fix missing option

Change History

Changed 15 years ago by bilbo

Fix missing option

comment:1 Changed 15 years ago by bilbo

  • Status changed from new to accepted
  • Owner set to bilbo
  • Votes for changeset set to bilbo
  • Version changed from 4.7.0-pre3 to 4.7.0-pre4
  • severity changed from no branch to on review

Created branch 1746_passive_mode_over_proxy
Initial changeset: b32c9e4a2a15cd50a6a07ad85b1a587328bd2cfc

comment:2 Changed 15 years ago by andrew_b

Please write ticker number in 1st line of commit log. For example:

Ticket #1746: Fix: "Use passive mode over proxy" option is not remembered in config

See ​ApplyingPatchGuidelines

comment:3 Changed 15 years ago by angel_il

fix:
Please write ticker number in 1st line of commit log. For example:

Ticket #1746 (Setting "Use passive mode over proxy" is not remembered)

    Fix: "Use passive mode over proxy" option is not remembered in config

or

Ticket #1746: Setting "Use passive mode over proxy" is not remembered

    Fix: "Use passive mode over proxy" option is not remembered in config

comment:4 Changed 15 years ago by slavazanko

Branch rebased because comment of commit was changed.

New initial changeset:2cfed22012ded42c2f4f47a13edc05bf405842db

comment:5 Changed 15 years ago by slavazanko

  • Votes for changeset changed from bilbo to slavazanko
  • Milestone changed from 4.7 to 4.7.0

comment:6 Changed 15 years ago by andrew_b

  • Votes for changeset changed from slavazanko to slavazanko andrew_b
  • severity changed from on review to approved

comment:7 Changed 15 years ago by bilbo

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko andrew_b to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

Fixed 2cfed22012ded42c2f4f47a13edc05bf405842db

comment:8 Changed 15 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.