Ticket #1702 (closed defect: fixed)
MenuBar has mixed default+skin colors
| Reported by: | sergey-feo | Owned by: | andrew_b |
|---|---|---|---|
| Priority: | minor | Milestone: | 4.7.1 |
| Component: | mc-core | Version: | 4.7.0-pre3 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | Votes for changeset: | committed-master committed-stable |
Description
Please try the next skin:
[core]
_default_=lightgray;gray
selected=black;cyan
marked=yellow;gray
markselect=yellow;cyan
gauge=black;gray
input=white;black
reverse=gray;lightgray
[menu]
_default_=black;lightgray
menuhot=red;lightgray
menusel=black;green
menuhotsel=red;green
"Left, File, Command, Options, Right" line will have incorrect cyan background.
Press F9.
Line will have correct lighgray background.
Change History
comment:1 in reply to: ↑ description Changed 15 years ago by andrew_b
comment:2 Changed 15 years ago by sergey-feo
At first, gray color cannot be used as background one
Did you mean the phrases "The value of the foreground parameter fg can be anyone of these sixteen colors. However, on most terminals, the background color will can only be one of the colors listed in the first column"?
Do you mean that
[x] menuBar visible
option is alway on?
Yes.
For me, the background color of inactive visible main menu is cyan.
It should be redefinable by skin. If inactive visible main menu color will not redefinable then [menu] section will meaningless IMHO.
comment:3 Changed 15 years ago by andrew_b
- Summary changed from "Left, File, Command, Options, Right" line has mixed default+skin colors to MenuBar has mixed default+skin colors
comment:4 Changed 15 years ago by andrew_b
- Status changed from new to accepted
- Owner set to andrew_b
- severity changed from no branch to on review
- Milestone changed from 4.7 to 4.7.1
Created 1702_menubar_colors branch. Parent branch is master.
changeset:0d12e0def82b22f30c9c6bff9d50496ada0382c9
comment:6 Changed 15 years ago by angel_il
- Votes for changeset changed from slavazanko to slavazanko andrew_b angel_il
- severity changed from on review to approved
comment:7 Changed 15 years ago by andrew_b
- Status changed from accepted to testing
- Votes for changeset changed from slavazanko andrew_b angel_il to commited-master
- Resolution set to fixed
- severity changed from approved to merged
Merged to master.
changeset:0d12e0def82b22f30c9c6bff9d50496ada0382c9
At first, gray color cannot be used as background one (see http://www.s-lang.org/doc/html/cslang-8.html#ss8.4).
Replying to sergey-feo:
Do you mean that
option is alway on?
But anyway, I cannot confirm. For me, the background color of inactive visible main menu is cyan.