Ticket #1622 (closed defect: wontfix)

Opened 15 years ago

Last modified 15 years ago

Latest changes in viewer broke builds on RHEL4

Reported by: zaytsev Owned by:
Priority: critical Milestone: 4.7.0-pre3
Component: mcview Version: master
Keywords: Cc:
Blocked By: #1608 Blocking:
Branch state: Votes for changeset:

Description

Hi!

​http://rpm.zaytsev.net/mc-git/epel-4-i386/ <--- does not build anymore.

Patch by Slava Zanko:

diff --git a/src/viewer/Makefile.am b/src/viewer/Makefile.am
index ae1e491..20798b3 100644
--- a/src/viewer/Makefile.am
+++ b/src/viewer/Makefile.am
@@ -1,3 +1,4 @@
+AM_CFLAGS = $(GLIB_CFLAGS) -I$(top_srcdir) $(PCRE_CFLAGS)

 noinst_LTLIBRARIES = libmcviewer.la

Please commit and we shall see if it works next night.

Change History

comment:1 Changed 15 years ago by slavazanko

  • Status changed from new to closed
  • Resolution set to wontfix
  • Blocked By 380, 1608 added

well... PCRE_CFLAGS already in Makefile.am.

Reason of unsucessfull build is a #1608

But in #380 now we have lot of changes (as fact, #380 ready now for review, bay be some little bugs present in this branch:) ). In #380 bug from #1608 now fixed (and bug from this ticket fixed too). But if we will fix this ticket (and ticket:1608) may be some bugs added into #380 after rebasing of branch.

Just wait for merge #380 into master, please :).

comment:2 Changed 15 years ago by zaytsev

OK, will do! Thanks.

comment:3 Changed 15 years ago by slavazanko

  • Blocked By 380 removed

(In #380) merge changeset:dec8a5d26e72f447d89c5ecd5d8f7dcb43f5367e

Note: See TracTickets for help on using tickets.