mc segfault on F7 in viewer & editor on FreeBSD

[S_Paul]

try to search in some file - Segmentation fault: 11 (core dumped)

FreeBSD-7
git 4.7.0-pre2-68-g43537b0
Compiler: gcc -std=gnu99
Compiler flags: -g -O2 -Wall
File system: Midnight Commander Virtual File System

cpio, tar, ftp, fish, extfs, sfs

Screen library: S-Lang library (installed on the system)
Mouse support: xterm only
X11 events support: yes
With subshell support: yes
Internal editor: yes
Support for charset: yes
Search type: glib-regexp

[S_Paul]

mc.core

[iNode]

Please check at the latest master branch (your test on changeset 68, actual for now 84) and use search before reporting bugs. Also here described how to report segfaults, please read.

[S_Paul]

latest ..83..

[S_Paul]

attach

[S_Paul]

and thanks.

[andrew_b]

Created branch 1621_segfault_search_f7. Parent branch:master.
chahgeset:857e64a6ec1c31651d65de96e63b619dda21f6f4

Please test it.

[andrew_b]

Sorry...

changeset:857e64a6ec1c31651d65de96e63b619dda21f6f4

[S_Paul]

still segfault

[angel_il]

Replying to S_Paul:

still segfault

please attach last crash report.

[S_Paul]

ok

[andrew_b]

Please test again this branch.

[andrew_b]

(In #1623) Replying to dmartina:

I have been debugging this for a copuple of hours. I think I got some clues:

1) src/search/libc.c (251): mc_search_get_types_strings_array
ret = g_malloc0(sizeof(char) * sizeof(types_str) );

Is the last sizeof(types_str) giving the size of the array or just the size of a pointer? I tested it and always got 4 whatever I chopped the array! Here we need 4 strings plus a null. Should be fixed. I mean completely fixed.

Seems this bug and #1621 have the same root.

2) edit/editcmd_dialogs.c (122):editcmd_dialog_replace_show
When back from QuickDialog? the list_of_types has new string pointers with the same content. I suppose that these strings are translated twice, QuickDialog? is getting rid (gfree) of the second set and we get the error when trying to free the second set twice. Maybe it's just memory we try to steal from gettext if we didn't strdup somewhere... Memory leak: ¿where did the first set go?

Yepp. :(

3) If 2) is right we may avoid the _() call used in the 1) function.

I agree.

4) Cross fingers not to have many more side-effects.

[S_Paul]

stil segfault..
attach

[andrew_b]

The one piece of code is modified in several tickets. Thus set blockedby 1556.

[andrew_b]

(In #1556) Merged to master.
changeset:434ebd3780d400cffa274b96ea29614e668f58fc

All other dialogs will be fixed in #64.

[S_Paul]

is my reports help you?
something more?

[andrew_b]

Replying to S_Paul:

is my reports help you?

Yes. I'm working with this bug.

something more?

No.

[andrew_b]

Branch is completely rewritten. Please test.
changeset:2959b2697c095392172d5cf940bf3b781eef92c7
changeset:f7f5ccd7d8c219568bb9c4f18c75e9aeb7800e71

[sfionov]

I had the same problem on OpenSolaris? with Sun Studio compiler (in -m32 mode). mc built from master branch segfaults by pressing F7 or F4 in editor. Switching to ticket's branch helps, mc no longer segfaults.

[slavazanko]

Big thanks for your comment. In some situation (like this) we just beleive :)

[dmartina]

Now it doesn't crash. Code looks good.

[S_Paul]

stil segfault
only options - ./configure --enable-charset

[andrew_b]

The same prоblem. I have not any idea how to fix it. I believe that slavazanko will achieve success. :)

[S_Paul]

It works! thank to all!

[slavazanko]

It works! thank to all!

S_Paul, is it exactly? What about segfault.2.bz2 attachment?

[S_Paul]

да, i have some problem with brain :)
sorry for

[slavazanko]

Okay, if all good (and you sure) - you may vote for this branch.

S_Paul, dmartina: votes are present.

[S_Paul]

how? "resolve as?"

[iNode]

Enter you nickname in "Votes for changeset" field.

[slavazanko]

I'm downloaded FreeBSD-7.2 ISO image, then I'm installed FreeBSD into virtual mashine.

Well, trouble resolved. Vote here.

[dmartina]

OK

[slavazanko]

merge changeset:d450e8eb05c057f281eb20dd54f30282ea7c97d1