Ticket #1530 (closed defect: fixed)
Tricky format in view.c not suitable for i18n
| Reported by: | dmartina | Owned by: | angel_il |
|---|---|---|---|
| Priority: | blocker | Milestone: | 4.7.0-pre2 |
| Component: | mcview | Version: | 4.7.0-pre1 |
| Keywords: | i18n | Cc: | dmartina@… |
| Blocked By: | Blocking: | ||
| Branch state: | Votes for changeset: | committed-master |
Description
The format string is broken when read by gettext for l10n.
Attachments
Change History
Changed 15 years ago by dmartina
- Attachment view.c.diff added
comment:1 Changed 15 years ago by dmartina
- Priority changed from major to blocker
- Cc dmartina@… added
- Component changed from mc-core to mcview
comment:2 Changed 15 years ago by angel_il
- Status changed from new to accepted
- Owner set to angel_il
comment:4 Changed 15 years ago by angel_il
- Status changed from accepted to testing
- Resolution set to fixed
comment:6 in reply to: ↑ 3 ; follow-up: ↓ 7 Changed 15 years ago by dmartina
- Status changed from closed to reopened
- Resolution fixed deleted
comment:7 in reply to: ↑ 6 Changed 15 years ago by angel_il
Replying to dmartina:
Replying to angel_il:
fixed in #1557
#1557 seems to be failing...
no-no, after fix warnings 1557 will be merged with 'master'
your patch: d41e57a673cacb7dd46cf8f72c8a2e8386a2d95c
comment:9 Changed 15 years ago by angel_il
- Status changed from reopened to closed
- Resolution set to fixed
try again... fixed in #1557 :)
comment:10 Changed 15 years ago by slavazanko
- Blocked By 1557 removed
comment:11 Changed 15 years ago by angel_il
- Status changed from closed to reopened
- Resolution fixed deleted
sorry, i'm applied the patch incorrect :(
comment:12 Changed 15 years ago by angel_il
- severity changed from no branch to on review
- Blocking 1370 removed
branch: 1530_fix (origin: master)
changeset: b1546095cac2a0d45b99f9396ff02f3d5bace7ad
comment:14 Changed 15 years ago by slavazanko
- Votes for changeset changed from iNode to iNode slavazanko
- severity changed from on review to approved
looks good.
comment:15 Changed 15 years ago by angel_il
- Status changed from reopened to closed
- Votes for changeset changed from iNode slavazanko to commited-master
- Resolution set to fixed
- severity changed from approved to merged
Note: See
TracTickets for help on using
tickets.
Patch to build format string in runtime, not preprocessor.