Unitialized use of variable in edit.c

[metux]

gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -g -O2 -Wall -MT edit.o -MD -MP -MF .deps/edit.Tpo -c -o edit.o edit.c
edit.c: In function 'edit_cursor_move':
edit.c:1102: warning: 'c' may be used uninitialized in this function
mv -f .deps/edit.Tpo .deps/edit.Po

[winnie]

I think this is uncritical as c will get in every case initialised. However if you would like to get rid of this warning initialise c to -3. As this is the default return value for this function.

If you do this you could rewrite it partly in order to replace the four return calls with only one. (After the if clause).

[winnie]

Small patch which rewrites the return logic

[winnie]

I've added a small patch which should fix this warning

Please review.

[slavazanko]

I run 'grep' over sources for search calls of edit_cursor_move() function.

And not any case to checking return value of this function. As fact, this function will must non-return type ( void ).

See patch fix_uninitalised_int-rev2.patch.

Patch don't applyed to branch - I think that the rules of good manners: branch must change by developer, who created the branch. The rest (all those involved in the ticket, not just developers) is temporarily becoming subordinates, developer (branch-starter) is temporarily becoming team leader. If this idea good - need to update workflow ;)

[winnie]

As we are really doesn't use the returncode of this function it's okay to remove it and make it a void function.

[winnie]

This is now merged to mc-4.6 and master.

[winnie]

Closing