Multiple viewers and editors open concurrently with the file manager

[dborca]

Ok, this is my second-favourite patch :)
A nice feature of Advanced Midnight Commander mc-4.1.x-MP by Olegarch was the dialog selector. It allowed the user to have multiple viewers and editors open along with the main file manager. They can be switched at will. Note that this does NOT imply multi-threading, because there's no point for editors, viewers and file-managers to run in background; they primarily need user interaction.
The hotkeys for Multi Screen feature:
"M-`" selector
"M-," switch to previous
"M-." switch to next
Yes, I know the hotkeys are not very well-chosen, but I really tried hard to avoid clashes with existing hotkeys. (I just saw M-. was taken in GIT, but honestly, I don't need a hotkey to switch hidden files on and off very frequently; I can live with just a setting in Options for that :))
Patch (against 4.7.0-pre1) attached.

[andrew_b]

Please, don't include diffs of autogenerated stuff (Makefile.in, config.h.in, configure) into patches.

[angel_il]

and please dont gzip files before attach :)

[slavazanko]

is this related to #280?

[dborca]

Replying to slavazanko:

is this related to #280?

No. It is much, much better. :)

[angel_il]

is this related to #280?

No. It is much, much better. :)

i see :)
But what mcedit will do with unsaved opened files when the terminal will close?

[dborca]

Replying to angel_il:

is this related to #280?

No. It is much, much better. :)

i see :)
But what mcedit will do with unsaved opened files when the terminal will close?

That is handled by dlgswitch_before_exit(). The user is automatically switched to all editors with unsaved files (all others are closed). Switching is disabled when doing this, to prevent the user to do "smart" things. :)

[dborca]

Replying to angel_il:

is this related to #280?

No. It is much, much better. :)

i see :)
But what mcedit will do with unsaved opened files when the terminal will close?

Sorry, I just saw that I answered earlier what happens when Midnight will close. But probably you already knew that. :)

You asked "when the terminal will close". Well, the files remain unsaved and locks are left behind. But that is not a new problem, because I ask you: currently, when we have only one editor instance, what will happen with unsaved opened file when the terminal will close? It's just the same.

[angel_il]

Replying to dborca:

Replying to angel_il:

is this related to #280?

No. It is much, much better. :)

i see :)
But what mcedit will do with unsaved opened files when the terminal will close?

Sorry, I just saw that I answered earlier what happens when Midnight will close. But probably you already knew that. :)

yes, of course. Because I think about this many times. :)

You asked "when the terminal will close". Well, the files remain unsaved and locks are left behind. But that is not a new problem, because I ask you: currently, when we have only one editor instance, what will happen with unsaved opened file when the terminal will close? It's just the same.

When only one file is opened i will see that it is not saved. It's eyse...
but when them is opened much, it is much more difficult...
That why i do not allow to be switched to other file, while the current is not saved (in #280)

[angel_il]

branch: 1490_dlgswitch (parent: master)
changeset: 4c749491db57aa1f3555706d413094ce2b4a29f6

[andrew_b]

Patch and branch must be reworked to use glib functions as much as possible.

[andrew_b]

Also src/dlgswitch.[ch] are not in the branch.

[angel_il]

in dlgswitch.c i see:
Copyright (c) 2009 Daniel Borca All rights reserved

you mean:

Copyright (C) 2009 Free Software Foundation, Inc.

Written by: Daniel Borca

?

[dborca]

Yep. You can change that.

[angel_il]

Replying to dborca:

Yep. You can change that.

ok :), i'll fix it in branch...

[ossi]

without a written (on paper!) copyright assignment, dborca's copyright notice is the only legally relevant one anyway. of course, that applies equally to all code written by anyone else who did not sign such a paper.

[andrew_b]

Created 1490_multi_screens branch. Parent branch is master.
Initial changeset:af4a527077f580277e86718972870624b5215fcc

[andrew_b]

Rebased to current master.
Initial changeset:5373cf29fff57105ff65424b065cb286fadc7600

[andrew_b]

Merged to master.
changeset:9adda31a9f1accc0785f7dbd87d75a7f3af39f76

git log --pretty=oneline 104c2a0..9adda31

[andrew_b]

Exit from subshell is handled incorrectly.

Created 1490_exit_subshell_fix branch. Parent branch is master.
changeset:fb017ef20ae1a0ac23c754dd4df3fd1c04b066ad

[andrew_b]

Merged to master.
changeset:f86415f03e6997c0849fe04137fce889c4937513

[andrew_b]

Multi-screen angine doesn't handle correctly some cases.
Example:

1. Run mc.
2. Open some file in internal editor.
3. Switch back to the file panels.
4. Open another file in internal editors. As a result, two editors are opened.
5. Close current editor. Now you are in file panels.
6. Run screen list dialog (Meta-`).

6a. The 1st editor is highlighted as current screen. This is wrong. Current screen is file panels.
6b. Cannot switch to the opened editor in this dialog.

[zaytsev]

Just for the record: the same is true for viewers.

And, by the way, when you open Meta+` the cursor is blinking in a strange place. I would have expected it to blink in the lower bottom corner. However, the same is true for F2 dialog, so it's not a multiscreen problem as such.

[andrew_b]

Created 1490_multiscreen_fix branch. Parent branch is master.
changeset:451765a48314167ffca058b71e44c69409e63c6b

[andrew_b]

Merged to master.
changeset:451765a48314167ffca058b71e44c69409e63c6b

[andrew_b]

Sorry, changeset:6cfefe7cb768a5c97fd28881c4643563943183e3.

[andrew_b]

#2264 fixes segfault in "Advanced Chown" dialog.
#2284 fixes segfault in autocompletion.