Ticket #1457 (closed enhancement: fixed)
'File Find' dialog: new '[ ] Look at the first entry' option
| Reported by: | angel_il | Owned by: | andrew_b |
|---|---|---|---|
| Priority: | major | Milestone: | 4.7.0-pre2 |
| Component: | mc-core | Version: | master |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | Votes for changeset: | committed-master |
Description (last modified by angel_il) (diff)
if "Look at the first entry" swich on search for first entry and start search in next file.
┌────────────────────────── Find File ───────────────────────────┐ │ Start at: │ │ . [^] [ Tree ] │ │ │ │ File name: Content: │ │ * [^] [^] │ │ [x] Case sensitive [x] Case sensitive │ │ [x] Using shell patterns [ ] Regular expression │ │ [x] Find recursively [ ] All charsets │ │ [ ] Skip hidden [ ] Look at the first entry │ │ [ ] All charsets │ │ │ │ [< OK >] [ Cancel ] │ └────────────────────────────────────────────────────────────────┘
Change History
comment:2 Changed 15 years ago by andrew_b
- Summary changed from Option for find dialog [ ] All occurrences to 'File Find' dialog: new '[ ] All occurrences' option
Fixed summary.
comment:4 Changed 15 years ago by slavazanko
'All occurrences' - is this option for avoid duplicates of file names (if on one file found more than one string) in search results dialog?
comment:6 Changed 15 years ago by angel_il
- Description modified (diff)
- Summary changed from 'File Find' dialog: new '[ ] All occurrences' option to 'File Find' dialog: new '[ ] Look at the first entry' option
comment:7 Changed 15 years ago by andrew_b
- Owner set to andrew_b
- Status changed from new to accepted
- Priority changed from major to minor
- severity changed from no branch to on review
- Milestone changed from 4.7.0-pre3 to 4.7.0-pre2
Created branch 1457_findfile_first_entry. Parent branch: master.
changeset:e73bda29fd36c2db6881e76e273bb5be2e9e7f30
comment:8 Changed 15 years ago by ossi
i still don't get what the option is about, which is definitely a bad sign. please explain so we can come up with a useful name (if at all possible).
the patch seems to contain unrelated changes, which is bad practice.
comment:9 follow-up: ↓ 11 Changed 15 years ago by slavazanko
This new option need for avoid multiple entries into 'File search results' dialog.
For example, now search results displayed like:
367:configure.ac 370:configure.ac 372:configure.ac 43464:configure 43465:configure 43472:configure ...
With checked 'Look at the first entry' option same search query looks like:
367:configure.ac 43464:configure ...
Will show just first search results from files.
comment:10 Changed 15 years ago by slavazanko
the patch seems to contain unrelated changes, which is bad practice.
I'm agree. Need to split refactoring and feature-append works.
comment:11 in reply to: ↑ 9 Changed 15 years ago by ossi
Replying to slavazanko:
This new option need for avoid multiple entries into 'File search results' dialog.
ah, right. in that case i withdraw my initial comment (which obviously related to the issues in the editor) and claim the opposite. "only first hit for each file" is descriptive, but too long. "first hit only" is short enough, but might be misinterpreted as "stop after first hit *at all*". maybe "one hit per file"? "all occurrences" is rather undescriptive, but at least it doesn't suggest any particular (mis-)interpretation.
comment:12 Changed 15 years ago by andrew_b
Split to two commits and rebased.
changeset:aae815c576316464a1860defb12d1b6060c5442f -- code refactoring.
changeset:14da3f52b2b340eb4cd19a3b12156039e9f35351 -- new feature.
comment:14 Changed 15 years ago by angel_il
- Votes for changeset changed from slavazanko to slavazanko angel_il
- severity changed from on review to approved
comment:15 Changed 15 years ago by andrew_b
- Status changed from accepted to testing
- Resolution set to fixed
- severity changed from approved to merged
Merged to master.
start changeset:958246efd208d3e8a276146fe83c96153d89484e
finish changeset:595c261fa857a062c50f7de8fdcdf67e2d636753
comment:17 Changed 15 years ago by andrew_b
- Status changed from closed to reopened
- Priority changed from minor to major
- Votes for changeset slavazanko angel_il deleted
- Resolution fixed deleted
- severity changed from merged to on review
Since some bugs was found some bugs in this, ticket reopened.
Created 1457_findfile_first_entry_fix branch. Parent branch: master.
start changeset:176fe09208b2ad0658d22d3054c6442ee83e8402
finish changeset:dcb6db6870c702b78703ed8ced031a9f019db100
comment:18 follow-ups: ↓ 19 ↓ 20 Changed 15 years ago by dborca
Please add "Whole words only". No patch this time :)
comment:19 in reply to: ↑ 18 Changed 15 years ago by andrew_b
comment:20 in reply to: ↑ 18 Changed 15 years ago by angel_il
Replying to dborca:
Please add "Whole words only". No patch this time :)
no-no-no :)
in another ticket
comment:22 Changed 15 years ago by iNode
- Votes for changeset changed from angel_il to angel_il iNode
- severity changed from on review to approved
comment:23 Changed 15 years ago by andrew_b
- Status changed from reopened to closed
- Resolution set to fixed
Merged to master.
start changeset:fbd042889ae1e795f9639a61b76a7acf984b49ca
end changeset:54b6991a9c12e4bf0638e27c839cd928dd0ad962
comment:24 Changed 15 years ago by andrew_b
- Votes for changeset changed from angel_il iNode to commited-master
- severity changed from approved to merged
this is confusing; this term has a clear connotation with search&replace (i.e., the gratuitously broken functionality).
the typical naming is "search from cursor", "start at top" or so.
but modern editors tend not to have that option and instead wrap to the beginning when the search runs off the end, usually displaying a dialog to confirm this (kate) or just showing an indicator in the status line.