External editor won't open if there are spaces in EDITOR variable

[andreitch]

If there are spaces in the EDITOR environment variable, mc won't load it.

These first two examples work, but the last ones don't:

EDITOR=emacs mc
EDITOR=mcedit mc
EDITOR='emacs -nw' mc
EDITOR='mc -e' mc

I think it's a problem with my_system function (utilunix.c, line 128) when it calls execl and execlp. You can see by running this two little C programs that they don't work. The third one works as expected.

#include <unistd.h>

int main(int argc, char *argv[])
{
    execlp("sh", "sh", "emacs -nw", (char *)NULL);
    return 0;
}

#include <unistd.h>

int main(int argc, char *argv[])
{
    execl("sh", "sh", "-c", "emacs -nw", (char *)NULL);
    return 0;
}

#include <unistd.h>

int main(int argc, char *argv[])
{
    execlp("sh", "sh", "-c", "emacs -nw", (char *)NULL);
    return 0;
}

[slavazanko]

Created branch 1425_spaces_in_EDITOR (parent: master)

Initial changeset:deefd6f6570d20c0997d656d5d5f7c393dfc34ca

Review, please.

[slavazanko]

branch rebased - changeset:4a5f02698e5f2cf78cc84201f15a63000789d86a

[slavazanko]

Merge changeset:d268dcd5f30faf391b1e28fcf49ee763ec44d88b