Ticket #139 (closed task: fixed)
compatibility_move_mc_files() still needed ?
| Reported by: | metux | Owned by: | metux |
|---|---|---|---|
| Priority: | minor | Milestone: | 4.7 |
| Component: | mc-core | Version: | 4.6.1 |
| Keywords: | committed-master committed-mc-4.6 | Cc: | |
| Blocked By: | Blocking: | ||
| Branch state: | Votes for changeset: |
Description
Just came around the function compatibility_move_mc_files() which
seems to move old files like .mc.ini, .mc.hot, ... to .mc/.
Actually I can't remember ever having those files, so it might be
quite long ago and probably not needed anymore.
Should we drop it ?
Attachments
Change History
comment:2 Changed 16 years ago by Patrick Winnertz
Am Sonntag 04 Januar 2009 10:28:37 schrieb Ticket System:
This function was created back in 2002 (merged with function
do_compatibility_move which exists longer). As the logs suggested this move to
.mc was done at least in 1998 (see commit
551dec7a7fd7c555f20774418c6f1c13cec9ab48).
This is more than 10 years ago... I think we can remove this function without
doing anything bad.
Is someone uncomfortable with this?
Greetings
Winnie
Changed 16 years ago by slavazanko
- Attachment compatibility_move_mc_files-rev1.patch added
remove compatibility_move_mc_files stuff
comment:4 Changed 16 years ago by slavazanko
- Owner changed from winnie to slavazanko
See attached patch.
Also, branch 'compatibility_move_mc_files' was created.
comment:5 Changed 16 years ago by slavazanko
or simply see changeset:5deebd49a8b60b9c7c21cdebe9cb252f788037d0
I see, it's better than attach patch...
comment:7 Changed 16 years ago by Patrick Winnertz
As written prior, I think we can savely remove this function, therefore:
+1
comment:8 Changed 16 years ago by slavazanko
- Status changed from accepted to testing
- Resolution set to fixed
Patch applyed to 'master', branch 'compatibility_move_mc_files' deleted.
comment:9 Changed 16 years ago by andrew_b
- Milestone changed from 4.6.2 to 4.7
What about XDG Base Directory Specification?
Maybe we need move $HOME./mc to $XDG_CONFIG_HOME/mc (or to $HOME/.config/mc)? If yes, the compatibility_move_mc_files() function can be rewritten for this action.
comment:10 Changed 16 years ago by slavazanko
I think, need to create new ticket.
comment:11 Changed 16 years ago by Enrico Weigelt
- MC Ticket System <tickets@…> schrieb:
No, please let it where it is.
comment:12 Changed 16 years ago by slavazanko
- Status changed from testing to reopened
- Resolution fixed deleted
comment:13 Changed 16 years ago by metux
- Keywords approved-metux, approved-winnie, approve_count=2 added
Why reopened ?
comment:14 Changed 16 years ago by slavazanko
What about XDG Base Directory Specification?
I think, need to create new ticket.
No, please let it where it is.
status changed from testing to reopened
Why reopened ?
Because 'testing' state for new request by andrew_b is a not valid state, 'closed' state non-valid too...
comment:15 Changed 16 years ago by winnie
I would go for not moving the configuration file to .config/mc but instead leaving them where they are now. .. At least for the moment.
comment:16 Changed 16 years ago by slavazanko
I would go for not moving the configuration file to .config/mc but instead leaving them where they are now. .. At least for the moment.
+1. At this moment need to keep in ~/.mc
But in future may be this propose reviewed...
BTW, is we need to add milestones: 'future' and 'non-applicable'?
comment:17 Changed 16 years ago by metux
- Keywords vote-metux, vote-winnie, approved added; approved-metux, approved-winnie, approve_count=2 removed
comment:18 Changed 16 years ago by metux
- Keywords committed-master committed-mc-4.6 vote-metux vote-winnie added; vote-metux, vote-winnie, approved removed
comment:19 Changed 16 years ago by winnie
Well.. i would suggest to close this report now.. if we consider to reorder the configuration files in the future we should open another ticket.
comment:20 Changed 16 years ago by metux
- Keywords vote-metux vote-winnie removed
- Owner changed from slavazanko to metux
- Status changed from reopened to accepted
comment:21 Changed 16 years ago by metux
- Status changed from accepted to testing
- Resolution set to fixed
Does anybody know when the files were not in .mc/ ?
Since I use linux (7 years ago) this stuff was in .mc/