Ticket #135 (closed enhancement: invalid)

Opened 10 years ago

Last modified 9 years ago

[PATCH] Drop bundled libintl

Reported by: metux Owned by: metux
Priority: minor Milestone: 4.7
Component: mc-core Version: 4.6.1
Keywords: review Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description (last modified by metux) (diff)

Drop the bundled / builtin intl library - use system-installed one only.

changeset:73884c1abf7517724e88a47af39b3e414f41a06c
branch:135_drop_bundled_libintl

Attachments

external-intl.001.diff (1.3 KB) - added by anonymous 10 years ago.
Added by email2trac
external-intl.002.diff (17.2 KB) - added by anonymous 10 years ago.
Added by email2trac
autopoint.tar.gz (594 bytes) - added by slavazanko 10 years ago.

Change History

comment:1 Changed 10 years ago by metux

  • Status changed from new to assigned
  • Owner set to metux

comment:2 Changed 10 years ago by slavazanko

In 'master' branch (AKA latest cvs) intl library doesn't present and creating automatically by ./autogen.sh script...

Changed 10 years ago by anonymous

Added by email2trac

comment:3 Changed 10 years ago by anonymous

Drops copy-in and build of bundled libintl

comment:4 Changed 10 years ago by metux

  • Status changed from assigned to accepted
  • Summary changed from Drop bundled libintl to [PATCH] Drop bundled libintl

comment:5 Changed 10 years ago by winnie

  • Milestone set to 4.6.2

I think this should be fixed until we release 4.6.2.

comment:6 Changed 10 years ago by Enrico Weigelt

  • Ticket System <tickets@…> schrieb:

ACK. The patch isn't that big+complicated.

comment:7 Changed 10 years ago by slavazanko

it's reverted patch. I applyed it only with:

git-apply -p1 -R external-intl.001.diff

and I have error:

$ ./autogen.sh
...
lot of warnings related to ticket:133
...
Makefile.am:5: AM_GNU_GETTEXT used but `intl' not in SUBDIRS
configure.ac:106: required file `./ABOUT-NLS' not found
automake failed to generate Makefile.in
$lsb_release -a
LSB Version:    :core-3.1-ia32:core-3.1-noarch:core-3.2-ia32:core-3.2-noarch:desktop-3.1-ia32:desktop-3.1-noarch:desktop-3.2-ia32:desktop-3.2-noarch
Distributor ID: Fedora
Description:    Fedora release 10 (Cambridge)
Release:        10
Codename:       Cambridge
$ rpm -q autoconf
autoconf-2.63-1.fc10.noarch
$ rpm -q automake
automake-1.10.1-2.noarch
$ rpm -q gettext
gettext-0.17-8.fc10.i386

next:

$ touch ABOUT-NLS
$ ./autogen
...
config.status: creating doc/sr/mcserv.8
config.status: creating doc/sr/Makefile
config.status: error: cannot find input file: po/Makefile.in.in

comment:8 Changed 10 years ago by winnie

  • Milestone changed from 4.6.2 to 4.7

Enrico?
As far as I see this: Is this (at least) partly a bugfix? Or only some kind of restructurement in your eyes? As far as I see it we should move it to 4.7 and not to 4.6.2 (apply it only on master branch and not on mc-4.6.2) branch.

comment:9 Changed 10 years ago by metux

  • Keywords rework added

@winnie: it's more an cleanup which should not change any functionality or interface.

Can we add an "cleanup" ticket type ?

Changed 10 years ago by anonymous

Added by email2trac

comment:10 Changed 10 years ago by anonymous

second take

comment:11 Changed 10 years ago by metux

  • Keywords review added; rework removed

comment:12 Changed 10 years ago by metux

  • Description modified (diff)

comment:13 Changed 10 years ago by slavazanko

I'm really don't understand why we need to drop intl stuff.

See next attach, for example.

After downloading try:

$ cd /tmp
$ tar xf /path/to/dovnloaded/autopoint.tar.gz
$ cd autopoint
$ ls
autogen.sh  configure.ac  Makefile.am  src
$ ./autogen

All except 'autogen.sh configure.ac Makefile.am src' files is autogenerated stuff and need to add into .gitignore file

why we need to don't use autopoint utility?

Changed 10 years ago by slavazanko

comment:14 Changed 10 years ago by metux

  • Description modified (diff)

rebased to master

comment:15 Changed 9 years ago by slavazanko

  • Status changed from accepted to testing
  • Resolution set to invalid

I think, autopoint stuff need to keep at this time. If someone don't agree - reopen this ticket, please

comment:16 Changed 9 years ago by styx

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.