Changes between Version 4 and Version 7 of Ticket #118


Ignore:
Timestamp:
01/11/14 23:22:12 (6 years ago)
Author:
ossi
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #118

    • Property Status changed from testing to closed
    • Property Keywords vote-styx vote-metux removed
    • Property Branch state changed from to no branch
    • Property Reporter changed from slavazanko to palos
  • Ticket #118 – Description

    v4 v7  
    11Original: http://savannah.gnu.org/bugs/?18042 
    22 
    3 ||Submitted by:||Palo Simo <palos>|| 
    4 Submitted on:||Tue 17 Oct 2006 12:51:17 PM UTC|| 
     3||Submitted by:||Palo Simo <palos>||Submitted on:||Tue 17 Oct 2006 12:51:17 PM UTC|| 
    54||Category:||VFS||Severity:||3 - Normal|| 
    65||Status:||Ready For Test||Privacy:||Public|| 
     
    87||Release:||current (CVS or snapshot)||Operating System:||All|| 
    98 
    10 Discussion: 
     9Original submission: 
    1110{{{ 
    12 Mon 30 Oct 2006 08:11:45 PM UTC, comment #4: 
     11this is a feature request: 
     12include the ability to specify port number to connect to in the shell link to machine feature 
     13}}} 
    1314 
    14 Thank you for the patch, it is working okay, great! 
    15 I do not use any of the other options, so I don't know if they are affected - I think you know whether or not ... 
    16         Palo Simo <palos> 
    17 Mon 30 Oct 2006 12:04:54 PM UTC, comment #3: 
     15Comment 1 by Andrew V. Samoilov <sav> at Fri 27 Oct 2006 12:15:02 PM UTC: 
     16{{{ 
     17Hello, Palo. 
    1818 
     19Please test attached patch. This changes have to be documented in manuals before commit to CVS. 
     20 
     21vfs/ChangeLog: 
     22 
     23    * fish.c: Iterpret SUP.flags as port number if SUP.flags is not in 0, FISH_FLAG_COMPRESSED and FISH_FLAG_RSH. Weakness: port number 
     24 
     25and r and C option cannot be used together. 
     26Port 1 will be interpretted as 'C' option, port 2 as 'r'. 
     27 
     28(fish_open_archive_int): Change for above. 
     29(fish_fill_names): Likewise. 
     30}}} 
     31 
     32Comment 2 by Leonard den Ottolander <leonardjo> at Sat 28 Oct 2006 12:43:20 PM UTC: 
     33{{{ 
     34> Weakness: port number 
     35> and r and C option cannot be used together. 
     36> Port 1 will be interpretted as 'C' option, port 2 as 'r'. 
     37 
     38 
     39Do I understand correctly that a port number can be combined with C or r? And does one have to specify a port number if one uses 'r'? Please explain any syntax changes that you introduced. 
     40 
     41From what I remember from earlier investigations to separate out the port from the other options we need to add an extra variable to some of the functions. Am I mistaken? 
     42 
     43Maybe it's best first to decide on a new option syntax that allows all combinations and then implement that new syntax? 
     44}}} 
     45 
     46Comment 3 by Andrew V. Samoilov <sav> at Mon 30 Oct 2006 12:04:54 PM UTC: 
     47{{{ 
    1948> Do I understand correctly that a port number can be combined with C or r? And does one have to specify a port number if one uses 'r'? Please explain any syntax changes that you introduced. 
    2049 
     
    3665 
    3766I am not sure we can allow such redesign because of lack of manpower. 
    38         Andrew V. Samoilov <sav> 
    39 Project MemberIn charge of this item. 
    40 Sat 28 Oct 2006 12:43:20 PM UTC, comment #2: 
     67}}} 
    4168 
    42 > Weakness: port number 
    43 > and r and C option cannot be used together. 
    44 > Port 1 will be interpretted as 'C' option, port 2 as 'r'. 
    45  
    46  
    47 Do I understand correctly that a port number can be combined with C or r? And does one have to specify a port number if one uses 'r'? Please explain any syntax changes that you introduced. 
    48  
    49 From what I remember from earlier investigations to separate out the port from the other options we need to add an extra variable to some of the functions. Am I mistaken? 
    50  
    51 Maybe it's best first to decide on a new option syntax that allows all combinations and then implement that new syntax? 
    52         Leonard den Ottolander <leonardjo> 
    53 Project Member 
    54 Fri 27 Oct 2006 12:15:02 PM UTC, comment #1: 
    55  
    56 Hello, Palo. 
    57  
    58 Please test attached patch. This changes have to be documented in manuals before commit to CVS. 
    59  
    60 vfs/ChangeLog: 
    61  
    62     * fish.c: Iterpret SUP.flags as port number if SUP.flags is not in 0, FISH_FLAG_COMPRESSED and FISH_FLAG_RSH. Weakness: port number 
    63  
    64 and r and C option cannot be used together. 
    65 Port 1 will be interpretted as 'C' option, port 2 as 'r'. 
    66  
    67 (fish_open_archive_int): Change for above. 
    68 (fish_fill_names): Likewise. 
    69         Andrew V. Samoilov <sav> 
    70 Project MemberIn charge of this item. 
    71 Tue 17 Oct 2006 12:51:17 PM UTC, original submission: 
    72  
    73 this is a feature request: 
    74 include the ability to specify port number to connect to in the shell link to machine feature 
     69Comment 4 by Palo Simo <palos> at Mon 30 Oct 2006 08:11:45 PM UTC: 
     70{{{ 
     71Thank you for the patch, it is working okay, great! 
     72I do not use any of the other options, so I don't know if they are affected - I think you know whether or not ... 
    7573}}} 
    7674 
    7775committed-master 
    7876changeset:a1b47185c952e9d31607d59420a0cb86e9f492ab 
    79