__group__ ticket summary component milestone type created _changetime _description _reporter andrew_b 4213 mc crashes on startup with subshell support as default in Freebsd mc-core Future Releases defect 2021-02-25T22:21:09Z 2024-01-21T14:55:06Z " At first I thought it was a problem in my version of the system and opened a [https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253831 ticket there]. After discussing crashdump, we think the problem is mc. mc on the system can be run guaranteed with the `-u` option (--nosubshell). [https://mega.nz/folder/Qpxgwaxb#6QRwPG7A4s_AgswqUd5EKw Here] are the archives for the application mc (under FreeBSD) and crashdump mc.core. I am ready to provide additional information upon request. Backtrace full is: {{{ (gdb) bt full #0 0x00000000002c8aa6 in str_utf8_make_make_term_form (text=0x0, length=18446744073709551615) at strutilutf8.c:454 result = { text = ""\000 \000valid)\000 2021\000\061\000\000\273ь\000...\000\200\000\271ки\000\210...\000\201\000\200ования файлов"", '\000' , width = 0, compose = 0} uni = 0 left = 0 actual = 0x34e410 """" #1 0x00000000002c7bfd in str_utf8_term_width2 (text=0x0, length=18446744073709551615) at strutilutf8.c:802 result = 0x0 #2 0x00000000002c7c3c in str_utf8_term_width1 (text=0x0) at strutilutf8.c:811 No locals. #3 0x00000000002c2359 in str_term_width1 (text=0x0) at strutil.c:654 No locals. #4 0x000000000029c13f in setup_cmdline () at layout.c:976 mw = 0x801a95c00 prompt_width = 174 y = 1 tmp_prompt = 0x0 #5 0x000000000029b179 in setup_panels () at layout.c:889 mw = 0x801a95c00 start_y = 1 #6 0x000000000026320e in midnight_callback (w=0x801a95c00, sender=0x0, msg=MSG_INIT, parm=0, data=0x0) at filemanager.c:1498 command = 0 #7 0x00000000002516da in send_message (w=0x801a95c00, sender=0x0, msg=MSG_INIT, parm=0, data=0x0) at ../../lib/widget/widget-common.h:243 ret = MSG_NOT_HANDLED #8 0x000000000025155b in dlg_init (h=0x801a95c00) at dialog.c:503 g = 0x801a95c00 wh = 0x801a95c00 #9 0x0000000000251d95 in dlg_run (h=0x801a95c00) at dialog.c:574 No locals. #10 0x00000000002630dd in do_nc () at filemanager.c:1837 ret = 8 #11 0x000000000023dce0 in main (argc=1, argv=0x7fffffffda58) at main.c:463 mcerror = 0x0 config_migrated = 0 config_migrate_msg = 0x0 exit_code = 1 }}} {{{ # env LC_MESSAGES=C mc -V GNU Midnight Commander 4.8.26 Built with GLib 2.66.7 Built with S-Lang 2.3.2 with terminfo database With builtin Editor With subshell support as default With support for background operations With mouse support on xterm With support for X11 events With internationalization support With multiple codepages support Virtual File Systems: cpiofs, tarfs, sfs, extfs, ftpfs, sftpfs, fish Data types: char: 8; int: 32; long: 64; void *: 64; size_t: 64; off_t: 64; }}} {{{ # env LC_MESSAGES=C mc -F Home directory: /root Profile root directory: /root [System data] Config directory: /usr/local/etc/mc/ Data directory: /usr/local/share/mc/ File extension handlers: /usr/local/libexec/mc/ext.d/ VFS plugins and scripts: /usr/local/libexec/mc/ extfs.d: /usr/local/libexec/mc/extfs.d/ fish: /usr/local/libexec/mc/fish/ [User data] Config directory: /root/.config/mc/ Data directory: /root/.local/share/mc/ skins: /root/.local/share/mc/skins/ extfs.d: /root/.local/share/mc/extfs.d/ fish: /root/.local/share/mc/fish/ mcedit macros: /root/.local/share/mc/mc.macros mcedit external macros: /root/.local/share/mc/mcedit/macros.d/macro.* Cache directory: /root/.cache/mc/ }}} {{{ # env LC_MESSAGES=C mc --configure-options '--with-internal-edit' '--enable-charset' '--enable-nls' '--enable-vfs-sftp' '--with-screen=slang' '--with-slang-includes=/usr/local/include' '--disable-vfs-smb' '--without-smb-configdir' '--without-smb-codepagedir' '--with-subshell' '--disable-x' '--prefix=/usr/local' '--localstatedir=/var' '--mandir=/usr/local/man' '--disable-silent-rules' '--infodir=/usr/local/share/info/' '--build=amd64-portbld-freebsd12.2' 'build_alias=amd64-portbld-freebsd12.2' 'CC=cc' 'CFLAGS=-pipe -DLIBICONV_PLUG -g -fstack-protector-strong -fno-strict-aliasing ' 'LDFLAGS= -L/usr/local/lib -fstack-protector-strong ' 'LIBS=' 'CPPFLAGS=-I/usr/local/include -DLIBICONV_PLUG' 'CPP=cpp' 'PKG_CONFIG=pkgconf' }}} {{{ # uname -a FreeBSD vb-12.2.0.domain.com 12.2-STABLE FreeBSD 12.2-STABLE #0 r369260M: Sat Feb 13 11:28:24 EET 2021 root@vb-12.2.0.domain.com:/usr/obj/usr/src/amd64.amd64/sys/vb-12.2.0.domain.com.1 amd64 }}} " support.od.ua andrew_b 4258 Wrong subshell prompt parsing with fish 3.3.0 mc-core Future Releases defect 2021-06-30T11:59:18Z 2022-04-05T10:07:51Z "Fish 3.3.0 sends \r while printing prompt and mc erases prompt buffer This change was introduced by https://github.com/fish-shell/fish-shell/pull/8011 It starts working after I modify parse_subshell_prompt_string function: {{{ /* Extract the prompt from the shell output */ for (i = 0; i < bytes; i++) - if (buffer[i] == '\n' || buffer[i] == '\r') + if (buffer[i] == '\n') g_string_set_size (subshell_prompt_temp_buffer, 0); else if (buffer[i] != '\0') g_string_append_c (subshell_prompt_temp_buffer, buffer[i]); }}} " olfway andrew_b 4424 Cannot enter into extfs archive with file(s) in the parent directory mc-vfs Future Releases defect 2023-01-07T06:29:52Z 2024-01-21T14:54:38Z "From #4422. zip archive can contain files outside archive root: https://midnight-commander.org/attachment/ticket/4422/tmp.zip {{{ $ unzip -l tmp.zip Archive: tmp.zip Length Date Time Name --------- ---------- ----- ---- 0 2023-01-04 19:43 a 0 2023-01-04 19:43 b 0 2023-01-04 19:43 ../c 0 2023-01-04 19:43 ../../d --------- ------- 0 4 files }}} MC cannot enter into such archive. " andrew_b andrew_b 4532 Preserve ext2fs attributes on copy/move operations mc-core 4.8.32 enhancement 2024-03-24T16:20:25Z 2024-03-24T16:25:03Z Preserve ext2fs attributes on copy/move operations andrew_b andrew_b 2314 Freedesktop standard .desktop entry for Midnight Commander mc-core Future Releases enhancement 2010-08-20T16:07:32Z 2023-01-06T15:16:44Z "It would be nice if Midnight Commander would appear in menu's by default. This version I've attached is per latest Freedesktop.org menu-spec standard ( http://standards.freedesktop.org ) 1. Install this file: http://www.midnight-commander.org/chrome/site/MidnightCommander.png To path: /usr/share/icons/hicolor/64x64/apps/MidnightCommander.png 2. Install attached file, ""MidnightCommander.desktop"": To path: /usr/share/applications/MidnightCommander.desktop" ssuominen mooffie 3767 Document the left/right menu panelize command documentation Future Releases defect 2017-01-27T16:49:50Z 2021-04-08T06:22:53Z "I can't find any information in the internal help, or man page, or wiki, about the ""Panelize"" command in the ""Left"" or ""Right"" menu. I suspect this is related to the (well documented) ""External panelize"" command, but when I select it, I'm left clueless with an empty panel. Now what? " cri slavazanko 1483 Panel scrollbar mc-core Future Releases enhancement 2009-08-06T21:52:09Z 2021-12-18T12:43:44Z "The following patch adds a primitive scroll indicator to the file panels. It will display only on the active panel, and only if necessary. Attached patch (against 4.7.0-pre1) does this." dborca slavazanko 1488 Mountpoint selector mc-core Future Releases enhancement 2009-08-06T23:00:13Z 2022-06-26T12:23:12Z "A nice feature of Advanced Midnight Commander mc-4.1.x-MP by Olegarch was the mountpoint selector. I ported it back to MC. Very useful, especially in conjunction with automounters for USB sticks, CDs, etc. F11 (Shift-F1) and F12 (Shift-F2) will display the mountpoints selectors for each panel. Patch (against 4.7.0-pre1) attached. " dborca slavazanko 1581 Tabs or tab equivalent proposed mc-core Future Releases enhancement 2009-09-03T20:44:57Z 2020-09-07T10:35:03Z "Many users has expirience with tabbed applications like firefox and support for tabs in mc can be usefull. Please describe your opinion about topic. What use case you see for tabs? How it should looks like? Should it be clickable tabs like firefox/vim, or buffers like emacs/far manager? {{{ andre> i don't know emacs/far manager - but i like the tabs in vim, however - buffers in vim are awesom, too }}} " iNode slavazanko 2979 More user friendly bookmark management mcedit Future Releases enhancement 2013-03-14T13:27:21Z 2017-06-25T16:12:04Z "It will be nice, if user can: - remove bookmarks individualy - show up a bookmark list to select and remove bookmarks (like directory hotlist in filemanager)" szaszg slavazanko 3100 Embedded torrent viewer/vfs mc-vfs Future Releases enhancement 2013-10-18T09:54:55Z 2019-03-18T13:51:21Z "Currently ext.d viewer for torrent is partially broken since ctorrent is used and it broken in most distributions (http://sourceforge.net/p/dtorrent/bugs/21/). Attached patch adds viewer and vfs support based on script found here: http://phdru.name/Software/mc/torrent " eugenesan slavazanko 1875 [METATICKET] Change user configuration mc-config-ini Future Releases task 2009-12-15T07:31:27Z 2011-11-06T07:28:39Z "1. Move user mc configuration into ~/.config/mc in according with [http://standards.freedesktop.org/basedir-spec/basedir-spec-0.7.html FDO standard] (#1851). 2. Split [Midnight-Commander] section to several sections. 3. Store options of all dialogs (as possible) in config (#1572, #1874)" andrew_b slavazanko 2151 Odd behavior when opening ZIP file that contains the same file twice mc-vfs Future Releases defect 2010-04-22T20:02:48Z 2013-12-04T19:55:11Z "Forwarded from Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=347738 {{{ From: Marco Herrn To: Debian Bug Tracking System Subject: when opening zip file that contains the same file twice, mc behaves oddly Date: Thu, 12 Jan 2006 13:09:43 +0100 When a zip file contains a file with the same path and name more than once, mc doesn't display all the information. For example the bribblebox from bribble.com (available from http://prdownloads.sourceforge.net/bribble/bribble-1.5.35.tar.bz2?download) contains a Java Archive File (jar) which is in fact a zipfile with a specific structure (The jarfile is bribble-1.5.35/server/bribble-1_5_35.jar). This archive contains the file META-INF/MANIFEST.MF twice. (Of course this is wrong and the jar-file can be considered broken). These two MANIFEST.MF files have different content, so they can be distinguished. When opening this file in mc, there are two META-INF directories, each of which contains two MANIFEST.MF files. When viewing these MANIFEST.MF files (via F3), all four show the content of the same one. It would be of course better, if mc would display only one META-INF directory with two MANIFEST.MF files. And viewing them should of course display the correct contents, not the same content for both. I hope I made the problem clear. It can be easily reproduced by downloading the above mentioned tar.bz2, unpacking it and viewing the jar-file in mc. To view the actual contents, the unzip tool can be used, for example 'unzip -l bribble-1.5.35/server/bribble-1_5_35.jar' Regards Marco }}} I would have fixed this bug, but I don't know Perl :-( I think that duplicate directories should be trivial to filter, but I am not sure of what to do with duplicate files. If you give them the same name, then the VFS will not able to tell which one to show. If you give them different name it's not obvious that these files are duplicate. Maybe give them different names like with a special character that can not occur in the filenames? Then it's quite obvious that there's something wrong with the archive. Thanks!" zaytsev slavazanko 2657 SEGV when loading directory hotlist during startup mc-core Future Releases defect 2011-10-30T09:53:30Z 2017-08-05T08:28:02Z "during the startup of mc you can press ctrl+\ for the directory hotlist. when mc is not already 'in memory' eg filecache and not visible yet the application is closed with a SEGV signal. reproduce: type mc\n press ctrl+\ received result: Segmentation Fault expected result: started with the directory hotlist visible workarround: type mc again so far i was not able to debug this problem because it seems like a race condition (keys are received before curses are loaded) and most of the time mc loads faster than i am able to press 'ctrl+\'. situations when this bug occurs are - a fresh reboot - memory swapped out - heavy load - io wait for nfs/sshfs shares this problem has been persistent in the last years between 4.5 and 4.7, unless the startup sequence is changed it should be persistent in the current versions too $ mc --version GNU Midnight Commander 4.7.5.2 Built with GLib 2.28.8 Using the ncurses library With builtin Editor With subshell support as default With support for background operations With mouse support on xterm and Linux console With support for X11 events With internationalization support With multiple codepages support Virtual File Systems: cpiofs, tarfs, sfs, extfs, ext2undelfs, ftpfs, fish Data types: char: 8; int: 32; long: 64; void *: 64; size_t: 64; off_t: 64; " c0da slavazanko 2830 Bash subshell history not written on exit mc-core Future Releases defect 2012-06-17T11:07:29Z 2019-08-08T20:30:51Z "Since Bash 4.2, closing with '''any''' signal will not cause it to write the command history. This is intended, see: http://www.mail-archive.com/bug-bash@gnu.org/msg08850.html The consequence is that leaving MC via F10 will make a Bash subshell forget its history, whereas leaving MC via ""exit"" in the subshell will work as expected. This is obviously not MC's fault, but still a regression and very annoying. My suggestion is to change ""exit_subshell()"" to actually issue the ""exit"" command to the subshell. Unfortunately, I'm not familiar enough with MC's internals to assess if that suggestion is viable. " josh slavazanko 2371 show current lines in viewer mcview Future Releases enhancement 2010-10-01T07:39:05Z 2011-10-29T16:46:22Z "its usefull to show current viewing lines in viewer, for example like: (727-774)/1511 " x905 slavazanko 2644 [PATCH] editor enhancements mcedit Future Releases enhancement 2011-10-23T12:05:50Z 2012-05-25T13:58:09Z "Please find attached the patch referred to in this 4.8.0 discussion [ru]: http://www.opennet.ru/openforum/vsluhforumID3/80882.html#33 http://www.opennet.ru/openforum/vsluhforumID3/80882.html#182 It's neither authored nor edited by me (in fact I find some constants tasteless) but provided here in hope that the code or the idea will be useful." gvy zaytsev 1685 Missing support for archives with encrypted headers (rar, 7z and probably more) mc-vfs Future Releases defect 2009-10-09T11:17:34Z 2022-11-21T17:17:56Z "If rar archive is packed with option '-hp' midnight commander stalls on open attempt of such archive. The only workaround is to do: killall rar (if F3 was pressed) killall unrar (if Enter was pressed) After killing the rar/unrar process the ""enter password ..."" prompt is shown which is left from rar-process. For testing purposes it is necessary to create archive with the following sample command: $ rar a test_archive.rar * -hpmypassword" igorp1024 zaytsev 2088 """Show directory sizes"" usability regression versus 4.6.x" mc-core Future Releases defect 2010-03-06T11:35:39Z 2011-12-11T13:42:28Z "I upgraded to 4.7.1 from 4.6.2, and I noticed this huge (for me) usability regression regarding ""Show directory sizes"" feature. It seems that it was changed to show only the current directory size (like if you selected it in previous versions), and to show the sizes of all directories you have to scroll all the way to the top and do it on the "".."" entry. This presents a huge usability regression. Consider the following: I want to traverse a huge directory, one screenful of directories at a time, selecting the large ones (for example), and copying them to some other directory. Previously, I would just f9-c-i, then select some directories, copy them, then f9-c-i again (because any action clears the sizes), select some more directories, etc... Now I have to f9-c-i, select them, copy them, remember where I was (and I can't even select the directory I was on because it screws up the f9-c-i feature), scroll all the way to the top, press f9-c-i, then find the directory I was looking at (in a huge list of directories), and do the same each time mc clears the size fields. This clearly breaks the whole workflow. This is especially a big pain when working with different mc versions on different servers (the alt-o change was already bad enough). So please, instead of changing the behavior of existing features, consider adding new shortcuts for the new ones and/or configuration options for them." alex_sh zaytsev 2323 syntax hightlighting rule order bogus mcedit Future Releases defect 2010-08-26T09:12:23Z 2011-11-01T06:10:47Z "opening the file makefile.cpp in the editor causes it to be highlighted with Makefile syntax instead of C++ syntax. the fix is checking the extension rules first. " ossi zaytsev 3904 s3 vfs is broken mc-vfs Future Releases defect 2018-03-05T09:41:47Z 2024-01-21T14:54:53Z "start mc, type: cd s3:// (ensure relevant keys are present as env variables) After a few seconds, there is a long error dump, at the end: ssl.CertificateError: hostname u'[..].s3.amazonaws.com' doesn't match either of '*.s3.amazonaws.com', 's3.amazonaws.com' I investigated this a bit. It seems the current version of mc s3 extension uses boto, which is now deprecated by Amazon in favor of boto3 (check https://github.com/boto/boto/issues/2836). So, it needs a rewrite to boto3. I can help with this. Do you accept contributions? Thank you, Dan mc --version GNU Midnight Commander 4.8.20 Built with GLib 2.48.2 Using the S-Lang library with terminfo database With builtin Editor With subshell support as default With support for background operations With mouse support on xterm With internationalization support With multiple codepages support Virtual File Systems: cpiofs, tarfs, sfs, extfs, ftpfs, fish Data types: char: 8; int: 32; long: 64; void *: 64; size_t: 64; off_t: 64; " dan_tofan zaytsev 2346 Sync PHP syntax highlighting with up do date language keywords mcedit Future Releases enhancement 2010-09-11T07:33:39Z 2011-11-06T07:32:59Z "* Add OOP keywords (interface, implements, try/catch etc) * Add predefined exceptions (Exception etc) * Add predefined interfaces (Iterator etc) * Add std JSON functions (json_encode etc) * Add minor std keywords missing in highlight file Attached diff was made over official v4.7.4 release " ianzag zaytsev 3755 Fix emacs keymap mc-key-bindings Future Releases enhancement 2017-01-11T19:00:03Z 2021-04-08T06:20:07Z It will be more consistent with emacs if the ctrl-w was mapped to cut(currently it is mapped to remove for mc dialogs). Bad_ptr