Ticket #4050: mc-4050-achown.c-cleanup-uninitialized-warning.patch

File mc-4050-achown.c-cleanup-uninitialized-warning.patch, 1.1 KB (added by and, 7 months ago)
  • src/filemanager/achown.c

    From 9fd5537f02654ef60355235c6fcab0fc1ee7aacf Mon Sep 17 00:00:00 2001
    From: Andreas Mohr <and@gmx.li>
    Date: Fri, 3 Apr 2020 09:31:20 +0000
    Subject: [PATCH] (achown.c): cleanup uninitialized warning
    
    Found by Clang 9.0.1
    
    achown.c:531:30: error: variable 'h' is uninitialized when used within its own initialization [-Werror,-Wuninitialized]
            WDialog *h = DIALOG (h);
                     ~           ^
    ../../lib/widget/dialog.h:19:32: note: expanded from macro 'DIALOG'
    #define DIALOG(x) ((WDialog *)(x))
                                   ^
    
    Signed-off-by: Andreas Mohr <and@gmx.li>
    ---
     src/filemanager/achown.c | 2 +-
     1 file changed, 1 insertion(+), 1 deletion(-)
    
    diff --git a/src/filemanager/achown.c b/src/filemanager/achown.c
    index 7a98bc069..7eb25ddc4 100644
    a b user_group_button_cb (WButton * button, int action) 
    528528    do 
    529529    { 
    530530        WGroup *g = w->owner; 
    531         WDialog *h = DIALOG (h); 
     531        WDialog *h = DIALOG (g); 
    532532        Widget *wh = WIDGET (h); 
    533533 
    534534        gboolean is_owner = (f_pos == BUTTONS_PERM - 2);