Ticket #3598: mc-3598-0011-widget-dialog.c-cleanup-Wcast-qual-warning.patch

File mc-3598-0011-widget-dialog.c-cleanup-Wcast-qual-warning.patch, 2.0 KB (added by and, 8 years ago)
  • lib/widget/dialog.c

    From 643254d461a4177efc2838aeea669c5de66bca97 Mon Sep 17 00:00:00 2001
    From: Andreas Mohr <and@gmx.li>
    Date: Sat, 20 Feb 2016 15:09:10 +0000
    Subject: [PATCH] widget/dialog.c: cleanup -Wcast-qual warning
    
    In file included from ../../lib/widget.h:18:0,
                     from dialog.c:43:
    dialog.c: In function 'dlg_find_widget_callback':
    ../../lib/widget/widget-common.h:13:20: warning: cast discards 'const' qualifier from pointer target type [-Wcast-qual]
     #define WIDGET(x) ((Widget *)(x))
                        ^
    dialog.c:202:23: note: in expansion of macro 'WIDGET'
         const Widget *w = WIDGET (a);
                           ^
    dialog.c:203:22: warning: cast discards 'const' qualifier from pointer target type [-Wcast-qual]
         widget_cb_fn f = (widget_cb_fn) b;
                          ^
    In file included from ../../lib/widget.h:18:0,
                     from dialog.c:43:
    dialog.c: In function 'dlg_find_widget_by_id':
    ../../lib/widget/widget-common.h:13:20: warning: cast discards 'const' qualifier from pointer target type [-Wcast-qual]
     #define WIDGET(x) ((Widget *)(x))
                        ^
    dialog.c:582:17: note: in expansion of macro 'WIDGET'
         Widget *w = WIDGET (a);
                     ^
    
    Signed-off-by: Andreas Mohr <and@gmx.li>
    ---
     lib/widget/dialog.c | 6 +++---
     1 file changed, 3 insertions(+), 3 deletions(-)
    
    diff --git a/lib/widget/dialog.c b/lib/widget/dialog.c
    index a53c046..19f9688 100644
    a b dlg_unfocus (WDialog * h) 
    199199static int 
    200200dlg_find_widget_callback (const void *a, const void *b) 
    201201{ 
    202     const Widget *w = WIDGET (a); 
    203     widget_cb_fn f = (widget_cb_fn) b; 
     202    const Widget *w = CWIDGET (a); 
     203    const widget_cb_fn f = b; 
    204204 
    205205    return (w->callback == f) ? 0 : 1; 
    206206} 
    frontend_dlg_run (WDialog * h) 
    579579static int 
    580580dlg_find_widget_by_id (gconstpointer a, gconstpointer b) 
    581581{ 
    582     Widget *w = WIDGET (a); 
     582    const Widget *w = CWIDGET (a); 
    583583    unsigned long id = GPOINTER_TO_UINT (b); 
    584584 
    585585    return w->id == id ? 0 : 1;